Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966215AbcKKC6Y (ORCPT ); Thu, 10 Nov 2016 21:58:24 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:47594 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965451AbcKKC6U (ORCPT ); Thu, 10 Nov 2016 21:58:20 -0500 Subject: Re: [PATCH] watchdog: jz4740: Fix modular build To: Stephen Boyd , Wim Van Sebroeck References: <20161111000220.12989-1-sboyd@codeaurora.org> Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Zubair Lutfullah Kakakhel From: Guenter Roeck Message-ID: Date: Thu, 10 Nov 2016 18:58:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161111000220.12989-1-sboyd@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1260 Lines: 34 On 11/10/2016 04:02 PM, Stephen Boyd wrote: > Compiling this driver as a module causes a build error because a > semicolon is missing after MODULE_DEVICE_TABLE. Add it. > > CC [M] drivers/watchdog/jz4740_wdt.o > drivers/watchdog/jz4740_wdt.c:154:1: error: expected ‘,’ or ‘;’ before ‘static’ > drivers/watchdog/jz4740_wdt.c:218:11: error: ‘jz4740_wdt_probe’ undeclared here (not in a function) > > Cc: Zubair Lutfullah Kakakhel > Cc: Guenter Roeck > Signed-off-by: Stephen Boyd Oops :-( Reviewed-by: Guenter Roeck > --- > drivers/watchdog/jz4740_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c > index c8d51ddb26d5..20627f22baf6 100644 > --- a/drivers/watchdog/jz4740_wdt.c > +++ b/drivers/watchdog/jz4740_wdt.c > @@ -148,7 +148,7 @@ static const struct of_device_id jz4740_wdt_of_matches[] = { > { .compatible = "ingenic,jz4740-watchdog", }, > { /* sentinel */ } > }; > -MODULE_DEVICE_TABLE(of, jz4740_wdt_of_matches) > +MODULE_DEVICE_TABLE(of, jz4740_wdt_of_matches); > #endif > > static int jz4740_wdt_probe(struct platform_device *pdev) >