Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965606AbcKKIyV (ORCPT ); Fri, 11 Nov 2016 03:54:21 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:38603 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964929AbcKKIyT (ORCPT ); Fri, 11 Nov 2016 03:54:19 -0500 X-AuditID: cbfee61a-f79916d0000062de-4e-58258739bd3a From: Shailendra Verma To: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] Staging: media: davinci_vpfe: - Fix for memory leak if Date: Fri, 11 Nov 2016 14:21:41 +0530 Message-id: <1478854301-25466-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsVy+t9jQV3LdtUIgxn9fBZ7zvxit2hevJ7N 4vKuOWwWPRu2slos2/SHyeLWvJlsFou+vWK2+HvxEpsDh8e9fYdZPHbOusvusWlVJ5vH/rlr 2D36tqxi9Pi8SS6ALcrNJiM1MSW1SCE1Lzk/JTMv3VYpNMRN10JJIS8xN9VWKULXNyRISaEs MacUyDMyQAMOzgHuwUr6dgluGS27n7IWHGGvWLS3l62BcStbFyMnh4SAicTnQ0tZIWwxiQv3 1gPFuTiEBGYxSky4t48ZwvnJKNGy7AkjSBWbgKHE676/TCAJEYF5TBIXm5eCjWIWkJHYN7EN KMHBISzgLvFiaSpImEVAVWLN6R6wXl4BD4mHDcfBSiQEFCTmTLKZwMi9gJFhFaNEakFyQXFS eq5hXmq5XnFibnFpXrpecn7uJkZw2D6T2sF4cJf7IUYBDkYlHl6JLNUIIdbEsuLK3EOMEhzM SiK8La1AId6UxMqq1KL8+KLSnNTiQ4ymQPsnMkuJJucDYyqvJN7QxNzE3NjAwtzS0sRISZy3 cfazcCGB9MSS1OzU1ILUIpg+Jg5OqQZGOQsXRt3HP6QWLlqp9ceGgVNNNXmj49/5m2VKX2Q9 Tdokq21rLnE77u38qGO3+VX3bfabX7loq9En9ZKZK8OCFSyyJ7r4xvCsOLxL2eTvJO1PxS8b vjTer/GP3uXHM3fu7Y5Y7wQv/o0Pv+jm3XQTczj461jZ3knqPxLyjFJDVs0+Xfk+pWSiEktx RqKhFnNRcSIAu5/++3ECAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 937 Lines: 25 From: "Shailendra Verma" Fix to avoid possible memory leak if the decoder initialization got failed.Free the allocated memory for file handle object before return in case decoder initialization fails. Signed-off-by: Shailendra Verma --- drivers/staging/media/davinci_vpfe/vpfe_video.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c index 8be9f85..80c2e25 100644 --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c @@ -423,6 +423,7 @@ static int vpfe_open(struct file *file) /* If decoder is not initialized. initialize it */ if (!video->initialized && vpfe_update_pipe_state(video)) { mutex_unlock(&video->lock); + kfree(handle); return -ENODEV; } /* Increment device users counter */ -- 1.7.9.5