Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756240AbcKKJSC (ORCPT ); Fri, 11 Nov 2016 04:18:02 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34547 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756042AbcKKJR7 (ORCPT ); Fri, 11 Nov 2016 04:17:59 -0500 Date: Fri, 11 Nov 2016 10:17:55 +0100 From: Daniel Vetter To: Maxime Ripard Cc: Daniel Vetter , David Airlie , Thomas Petazzoni , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hans de Goede , Chen-Yu Tsai , Laurent Pinchart , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/5] drm/sun4i: Add support for the overscan profiles Message-ID: <20161111091755.tfqizju5voazjrmm@phenom.ffwll.local> Mail-Followup-To: Maxime Ripard , Daniel Vetter , David Airlie , Thomas Petazzoni , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hans de Goede , Chen-Yu Tsai , Laurent Pinchart , linux-arm-kernel@lists.infradead.org References: <20161108085927.ibyett46cjgyfwu2@phenom.ffwll.local> <20161110145630.wvzlh6rxusrufv2r@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161110145630.wvzlh6rxusrufv2r@lukather> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: NeoMutt/20161104 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 33 On Thu, Nov 10, 2016 at 03:56:30PM +0100, Maxime Ripard wrote: > Hi Daniel, > > On Tue, Nov 08, 2016 at 09:59:27AM +0100, Daniel Vetter wrote: > > On Tue, Oct 18, 2016 at 10:29:38AM +0200, Maxime Ripard wrote: > > > Create overscan profiles reducing the displayed zone. > > > > > > For each TV standard (PAL and NTSC so far), we create 4 more reduced modes > > > by steps of 5% that the user will be able to select. > > > > > > Signed-off-by: Maxime Ripard > > > > tbh I think if we agree to do this (and that still seems an open question) > > I think there should be a generic helper to add these overscan modes with > > increased porches. Anything that only depends upon the sink (and > > overscanning is something the sink does) should imo be put into a suitable > > helper library for everyone to share. > > > > Or maybe even stash it into the probe helpers and call it for all TV > > connectors. Definitely not a driver-private thing. > > Last time we discussed it, my recollection was that you didn't want to > have generic code for it, but I'd be happy to implement it. > > I'll come up with something like that. Well I can flip-flop around with the nonsense I'm sometimes emitting ;-) Since you called me out, feel free to do whatever you want ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch