Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753655AbcKKKPW (ORCPT ); Fri, 11 Nov 2016 05:15:22 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36148 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbcKKKPU (ORCPT ); Fri, 11 Nov 2016 05:15:20 -0500 Date: Fri, 11 Nov 2016 13:14:39 +0300 From: "Kirill A. Shutemov" To: "Aneesh Kumar K.V" Cc: akpm@linux-foundation.org, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 2/2] mm: THP page cache support for ppc64 Message-ID: <20161111101439.GB19382@node.shutemov.name> References: <20161107083441.21901-1-aneesh.kumar@linux.vnet.ibm.com> <20161107083441.21901-2-aneesh.kumar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161107083441.21901-2-aneesh.kumar@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 621 Lines: 20 On Mon, Nov 07, 2016 at 02:04:41PM +0530, Aneesh Kumar K.V wrote: > @@ -2953,6 +2966,13 @@ static int do_set_pmd(struct fault_env *fe, struct page *page) > ret = VM_FAULT_FALLBACK; > page = compound_head(page); > > + /* > + * Archs like ppc64 need additonal space to store information > + * related to pte entry. Use the preallocated table for that. > + */ > + if (arch_needs_pgtable_deposit() && !fe->prealloc_pte) > + fe->prealloc_pte = pte_alloc_one(vma->vm_mm, fe->address); > + -ENOMEM handling? I think we should do this way before this point. Maybe in do_fault() or something. -- Kirill A. Shutemov