Date: Fri, 11 Nov 2016 11:22:55 +0100
From: Borislav Petkov <bp@suse.de>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: Andy Lutomirski <luto@amacapital.net>, Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        X86 ML <x86@kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Brian Gerst <brgerst@gmail.com>, Chen Yucong <slaoub@gmail.com>,
        Chris Metcalf <cmetcalf@mellanox.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>, Huang Rui <ray.huang@amd.com>,
        Jiri Slaby <jslaby@suse.cz>, Jonathan Corbet <corbet@lwn.net>,
        "Michael S . Tsirkin" <mst@redhat.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "Ravi V . Shankar" <ravi.v.shankar@intel.com>,
        Shuah Khan <shuah@kernel.org>, Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH 1/4] x86/cpufeature: Add User-Mode Instruction Prevention
 definitions
Message-ID: <20161111102255.dabxedhs7kgkn7d2@pd.tnic>
References: <1478585533-19406-1-git-send-email-ricardo.neri-calderon@linux.intel.com>
 <1478585533-19406-2-git-send-email-ricardo.neri-calderon@linux.intel.com>
 <CALCETrXGFm8pFzn3qCr_k7n=9OUiKtFXRT0bg6TebnrxkTeMRQ@mail.gmail.com>
 <1478665516.2533.2.camel@ranerica-desktop>
 <CALCETrXp-Xy+cWuJUakBoXWTu0oWDbX3zCK12u5-QJ4P-7TfdA@mail.gmail.com>
 <1478748283.2551.5.camel@ranerica-desktop>
 <20161110085833.zw6qgd7pshbni656@pd.tnic>
 <1478837287.2542.4.camel@ranerica-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1478837287.2542.4.camel@ranerica-desktop>
User-Agent: NeoMutt/20161014 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 372
Lines: 12

On Thu, Nov 10, 2016 at 08:08:07PM -0800, Ricardo Neri wrote:
> UMIP is enabled by setting a bit in CR4. If that bit is not supposed
> to be set, that could cause a #GP fault.

Yeah, you do check CPUID first, AFAICT, so you should be ok...

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--