Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756136AbcKKLYD (ORCPT ); Fri, 11 Nov 2016 06:24:03 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:17873 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755501AbcKKLYB (ORCPT ); Fri, 11 Nov 2016 06:24:01 -0500 Date: Fri, 11 Nov 2016 14:23:26 +0300 From: Dan Carpenter To: Shiva Kerdel Cc: stuart.yoder@nxp.com, devel@driverdev.osuosl.org, German.Rivera@freescale.com, gregkh@linuxfoundation.org, nipun.gupta@nxp.com, linux-kernel@vger.kernel.org, german.rivera@nxp.com, treding@nvidia.com, itai.katz@nxp.com Subject: Re: [PATCH 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t' Message-ID: <20161111112326.GG28701@mwanda> References: <20161111110740.1926-1-shiva@exdev.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161111110740.1926-1-shiva@exdev.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 38 On Fri, Nov 11, 2016 at 12:07:39PM +0100, Shiva Kerdel wrote: > Follow the kernel type preferrences of using 's16' over 'int16_t'. > > Signed-off-by: Shiva Kerdel > Acked-by: Stuart Yoder > --- > Changes for v2: > - corrected an error in the log message, wrote 's32' instead of 's16'. > Changes for v3: > - added the missing annotates. > Changes for v4: > - corrected patch subject to version 4. > > drivers/staging/fsl-mc/include/mc-bus.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fsl-mc/include/mc-bus.h b/drivers/staging/fsl-mc/include/mc-bus.h > index e915574..c7cad87 100644 > --- a/drivers/staging/fsl-mc/include/mc-bus.h > +++ b/drivers/staging/fsl-mc/include/mc-bus.h > @@ -42,8 +42,8 @@ struct msi_domain_info; > */ > struct fsl_mc_resource_pool { > enum fsl_mc_pool_type type; > - int16_t max_count; > - int16_t free_count; > + s16 max_count; My understanding is that this has to be signed because the design of this driver is that we keep adding devices until the the counter overflows. After that there are a couple tests for "if (WARN_ON(res_pool->max_count < 0)) " which prevent the driver from working again. This all seems pretty horrible. regards, dan carpenter