Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756138AbcKKLY5 (ORCPT ); Fri, 11 Nov 2016 06:24:57 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:32114 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754256AbcKKLY4 (ORCPT ); Fri, 11 Nov 2016 06:24:56 -0500 Date: Fri, 11 Nov 2016 14:24:27 +0300 From: Dan Carpenter To: Shiva Kerdel Cc: stuart.yoder@nxp.com, devel@driverdev.osuosl.org, German.Rivera@freescale.com, gregkh@linuxfoundation.org, nipun.gupta@nxp.com, linux-kernel@vger.kernel.org, german.rivera@nxp.com, treding@nvidia.com, itai.katz@nxp.com Subject: Re: [PATCH 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t' Message-ID: <20161111112426.GH28701@mwanda> References: <20161111110740.1926-1-shiva@exdev.nl> <20161111110740.1926-2-shiva@exdev.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161111110740.1926-2-shiva@exdev.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 32 On Fri, Nov 11, 2016 at 12:07:40PM +0100, Shiva Kerdel wrote: > Follow the kernel type preferrences of using 's32' over 'int32_t'. > > Signed-off-by: Shiva Kerdel > Acked-by: Stuart Yoder > --- > Changes for v2: > - None > Changes for v3: > - None > Changes for v4: > - corrected patch version number. > > drivers/staging/fsl-mc/include/mc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h > index a781a36..1c46c0c 100644 > --- a/drivers/staging/fsl-mc/include/mc.h > +++ b/drivers/staging/fsl-mc/include/mc.h > @@ -81,7 +81,7 @@ enum fsl_mc_pool_type { > */ > struct fsl_mc_resource { > enum fsl_mc_pool_type type; > - int32_t id; > + s32 id; Just use "int". regards, dan carpenter