Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756062AbcKKLsu (ORCPT ); Fri, 11 Nov 2016 06:48:50 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:36557 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbcKKLst (ORCPT ); Fri, 11 Nov 2016 06:48:49 -0500 X-AuditID: cbfee61b-f796f6d000004092-f2-5825b01f6cd4 From: Shailendra Verma To: Tomi Valkeinen , Michal Hocko , Dave Hansen , linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] Video: fbdev: Remove impossible condition. Date: Fri, 11 Nov 2016 17:16:33 +0530 Message-id: <1478864793-32667-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsVy+t9jAV35DaoRBmdO8li82NDOaHF51xw2 i/t9Dha35s1ks1j07RWzxfr5t9gs/l68xObA7rFz1l12j3knAz36tqxi9Fi/5SqLx/Eb25k8 Pm+SC2CLcrPJSE1MSS1SSM1Lzk/JzEu3VQoNcdO1UFLIS8xNtVWK0PUNCVJSKEvMKQXyjAzQ gINzgHuwkr5dglvGgudrWQsOcVS0rghvYHzG1sXIySEhYCLx/tx+dghbTOLCvfVgcSGBpYwS M5YIdzFyAdk/GSUe9+5kAkmwCRhKvO77C2aLgCSOXM4EsZkFZCT2TWwDiwsLWEu0z70INohF QFViw90JYAt4BTwkln1sY+li5ABapiAxZ5LNBEbuBYwMqxglUguSC4qT0nON8lLL9YoTc4tL 89L1kvNzNzGCg/SZ9A7Gw7vcDzEKcDAq8fBKZKlGCLEmlhVX5h5ilOBgVhLhFV8PFOJNSays Si3Kjy8qzUktPsRoCrR/IrOUaHI+MILySuINTcxNzI0NLMwtLU2MlMR5G2c/CxcSSE8sSc1O TS1ILYLpY+LglGpg3NMU0rSWQ2OHmNjUdTZdftaZljfyTBjPObm5Rv+Vux4oXZerVqQ3a+lX hkW7zm/WCv29dG3cyZ93rP/reWt9Lo7f9tHCvcM7dNKiS+nbTnEkmN5+rFzIvuyd7c2Q23yv 5thYs+4L4TWWsC6ebWypWyxlszHw3pbg3iMbz3KUPZN4Ha/TcTpGiaU4I9FQi7moOBEAG9Qe DmgCAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 30 xoffset and yoffset of struct fb_var_screeninfo are unsigned and so they can never be less than 0. Signed-off-by: Shailendra Verma --- drivers/video/fbdev/pvr2fb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c index a2564ab..23ada1f 100644 --- a/drivers/video/fbdev/pvr2fb.c +++ b/drivers/video/fbdev/pvr2fb.c @@ -460,13 +460,11 @@ static int pvr2fb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) set_color_bitfields(var); if (var->vmode & FB_VMODE_YWRAP) { - if (var->xoffset || var->yoffset < 0 || - var->yoffset >= var->yres_virtual) { + if (var->yoffset >= var->yres_virtual) { var->xoffset = var->yoffset = 0; } else { if (var->xoffset > var->xres_virtual - var->xres || - var->yoffset > var->yres_virtual - var->yres || - var->xoffset < 0 || var->yoffset < 0) + var->yoffset > var->yres_virtual - var->yres) var->xoffset = var->yoffset = 0; } } else { -- 1.7.9.5