Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756366AbcKKMLp (ORCPT ); Fri, 11 Nov 2016 07:11:45 -0500 Received: from mail-it0-f43.google.com ([209.85.214.43]:37892 "EHLO mail-it0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755906AbcKKMLn (ORCPT ); Fri, 11 Nov 2016 07:11:43 -0500 MIME-Version: 1.0 X-Originating-IP: [181.121.136.80] In-Reply-To: References: <1478540043-24558-1-git-send-email-stanimir.varbanov@linaro.org> From: Javier Martinez Canillas Date: Fri, 11 Nov 2016 09:11:42 -0300 Message-ID: Subject: Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver To: Hans Verkuil Cc: Stanimir Varbanov , Mauro Carvalho Chehab , Andy Gross , Bjorn Andersson , Stephen Boyd , Srinivas Kandagatla , Linux Media Mailing List , Linux Kernel , linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 734 Lines: 36 Hello Hans, On Fri, Nov 11, 2016 at 8:49 AM, Hans Verkuil wrote: > Hi Stanimir, > > Overall it looks good. As you saw, I do have some comments but nothing major. > > One question: you use qcom as the directory name. How about using qualcomm? > > It's really not that much longer and a bit more obvious. > > Up to you, though. > It seems qcom is more consistent to the name used in most subsystems for Qualcomm: $ find -name *qcom ./arch/arm/mach-qcom ./arch/arm64/boot/dts/qcom ./Documentation/devicetree/bindings/soc/qcom ./sound/soc/qcom ./drivers/pinctrl/qcom ./drivers/soc/qcom ./drivers/clk/qcom $ find -name *qualcomm ./drivers/net/ethernet/qualcomm > Regards, > > Hans > Best regards, Javier