Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756638AbcKKNfC (ORCPT ); Fri, 11 Nov 2016 08:35:02 -0500 Received: from mail-pg0-f52.google.com ([74.125.83.52]:36328 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756327AbcKKNfA (ORCPT ); Fri, 11 Nov 2016 08:35:00 -0500 Message-ID: <5825C712.5050009@linaro.org> Date: Fri, 11 Nov 2016 21:26:42 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: agustinv@codeaurora.org CC: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rjw@rjwysocki.net, lenb@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, timur@codeaurora.org, cov@codeaurora.org, agross@codeaurora.org, harba@codeaurora.org, jcm@redhat.com, msalter@redhat.com, mlangsdo@redhat.com, ahs3@redhat.com, astone@redhat.com, graeme.gregory@linaro.org, guohanjun@huawei.com, charles.garcia-tobin@arm.com, Lorenzo Pieralisi , Gabriele Paoloni , Shameerali Kolothum Thodi Subject: Re: [PATCH V6 2/3] ACPI: Add support for ResourceSource/IRQ domain mapping References: <1477687696-1509-1-git-send-email-agustinv@codeaurora.org> <1477687696-1509-3-git-send-email-agustinv@codeaurora.org> <42ff0a81-7836-11f6-58e0-979bd1d0be20@linaro.org> <60c1d53146c0aebd3a05095823229224@codeaurora.org> In-Reply-To: <60c1d53146c0aebd3a05095823229224@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1787 Lines: 49 On 11/10/2016 11:02 PM, agustinv@codeaurora.org wrote: > Hey Hanjun, > > On 2016-11-09 21:36, Hanjun Guo wrote: >> Hi Marc, Rafael, Lorenzo, >> >> Since we agreed to add a probe deferral if we failed to get irq >> resources which mirroring the DT does (patch 1 in this patch set), >> I think the last blocker to make things work both for Agustin and >> me [1] is this patch, which makes the interrupt producer and consumer >> work in ACPI, we have two different solution for one thing, we'd happy >> to work together for one solution, could you give some suggestions >> please? >> >> [1]: >> https://mail-archive.com/linux-kernel@vger.kernel.org/msg1257419.html >> >> Agustin, I have some comments below. >> >> On 2016/10/29 4:48, Agustin Vega-Frias wrote: >>> This allows irqchip drivers to associate an ACPI DSDT device to >>> an IRQ domain and provides support for using the ResourceSource >>> in Extended IRQ Resources to find the domain and map the IRQs >>> specified on that domain. >>> >>> Signed-off-by: Agustin Vega-Frias >>> --- >>> drivers/acpi/Makefile | 1 + >>> drivers/acpi/irqdomain.c | 119 >>> +++++++++++++++++++++++++++++++++++++++++++++++ >> >> Could we just reuse the gsi.c and not introduce a new >> file, probably we can change the gsi.c to irqdomain.c >> or something similar, then reuse the code in gsi.c. > > I was thinking just that after we chatted off-list. Great. > I might revisit and see what I come up with given that we already have > a device argument and we could pass the IRQ source there. Sorry, I'm little confused here, why we "already have a device argument"? in drivers/acpi/resource.c, it just use NULL as device and we can't pass dev directly for the API is using now, could you explain more? Thanks Hanjun