Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756556AbcKKOTz (ORCPT ); Fri, 11 Nov 2016 09:19:55 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:50463 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbcKKOTx (ORCPT ); Fri, 11 Nov 2016 09:19:53 -0500 Date: Fri, 11 Nov 2016 15:19:52 +0100 From: Peter Zijlstra To: Viresh Kumar Cc: Rafael Wysocki , Ingo Molnar , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , Juri Lelli , Robin Randhawa Subject: Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier Message-ID: <20161111141952.GJ3117@twins.programming.kicks-ass.net> References: <1acfffe798c0371e69ec1171f485499e7b49ed6d.1478858983.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1acfffe798c0371e69ec1171f485499e7b49ed6d.1478858983.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 653 Lines: 24 On Fri, Nov 11, 2016 at 03:52:21PM +0530, Viresh Kumar wrote: > @@ -456,8 +460,6 @@ static int sugov_init(struct cpufreq_policy *policy) > > out: > mutex_unlock(&global_tunables_lock); > - > - cpufreq_enable_fast_switch(policy); > return 0; > > fail: > @@ -468,6 +470,10 @@ static int sugov_init(struct cpufreq_policy *policy) > mutex_unlock(&global_tunables_lock); > > sugov_policy_free(sg_policy); > + > + disable_fast_switch: > + cpufreq_disable_fast_switch(policy); > + > pr_err("initialization failed (error %d)\n", ret); > return ret; > } Argh, no indented labels please. Please fix the 3 that snuck in while you're there.