Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932967AbcKKOoU (ORCPT ); Fri, 11 Nov 2016 09:44:20 -0500 Received: from mga02.intel.com ([134.134.136.20]:4418 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755744AbcKKOoS (ORCPT ); Fri, 11 Nov 2016 09:44:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,621,1473145200"; d="scan'208";a="2883674" Subject: Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function To: Oliver Neukum , =?UTF-8?Q?Bj=c3=b8rn_Mork?= References: <1478692735.2428.10.camel@suse.com> <8760nwj0l3.fsf@miraculix.mork.no> <87a8d7h9q1.fsf@miraculix.mork.no> <1478776957.2428.15.camel@suse.com> Cc: Kai-Heng Feng , Alan Stern , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org From: Mathias Nyman Message-ID: <5825D962.9090807@linux.intel.com> Date: Fri, 11 Nov 2016 16:44:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1478776957.2428.15.camel@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1328 Lines: 36 On 10.11.2016 13:22, Oliver Neukum wrote: > On Thu, 2016-11-10 at 12:09 +0100, Bjørn Mork wrote: >> Kai-Heng Feng writes: >>> On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: >>>> Oliver Neukum writes: >>>> >>>>> On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: >>>>> >>>>>> These problems could very well be caused by running at SuperSpeed >>>>>> (USB-3) instead of high speed (USB-2). >>> >>> Yes, it's running at SuperSpeed, on a Kabylake laptop. >>> >>> It does not have this issue on a Broadwell laptop, also running at SuperSpeed. >> >> Then I must join Oliver, being very surprised by where in the stack you >> attempt to fix the issue. What you write above indicates a problem in >> pci bridge or usb host controller, doesn't it? > > Indeed. And this means we need an XHCI specialist. > Mathias, we have a failure specific to one implementation of XHCI. > Could be related to resume singnalling time. Does the xhci fix for it in 4.9-rc3 help? commit 7d3b016a6f5a0fa610dfd02b05654c08fa4ae514 xhci: use default USB_RESUME_TIMEOUT when resuming ports. It doesn't directly explain why it would work on Broadwell but not Kabylake, but it resolved very similar cases. If not, then adding dynamic debug for xhci could show something. -Mathias