From: Steve Twiss <stwiss.opensource@diasemi.com>
To: Lee Jones <lee.jones@linaro.org>
CC: LINUX-KERNEL <linux-kernel@vger.kernel.org>,
        DEVICETREE <devicetree@vger.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Eduardo Valentin <edubezval@gmail.com>,
        Guenter Roeck <linux@roeck-us.net>,
        LINUX-INPUT <linux-input@vger.kernel.org>,
        LINUX-PM <linux-pm@vger.kernel.org>,
        LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        "Mark Rutland" <mark.rutland@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        "Support Opensource" <Support.Opensource@diasemi.com>,
        Wim Van Sebroeck <wim@iguana.be>, Zhang Rui <rui.zhang@intel.com>
Subject: RE: [PATCH V2 05/10] mfd: da9061: MFD core support
Thread-Topic: [PATCH V2 05/10] mfd: da9061: MFD core support
Thread-Index: AQHSL60dgxIzFISLqUqxZNhJNzN0RaDTr98AgAAKzjA=
Date: Fri, 11 Nov 2016 15:50:12 +0000
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7018CCE9AB0@SW-EX-MBX02.diasemi.com>
References: <cover.1477501000.git.stwiss.opensource@diasemi.com>
 <bf02595c2fa32ba0c4311e2d480321b811fc9cf5.1477501000.git.stwiss.opensource@diasemi.com>
 <20161111103734.GD13638@dell>
In-Reply-To: <20161111103734.GD13638@dell>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-kse-attachmentfiltering-interceptor-info: protection disabled
x-kse-serverinfo: sw-ex-cashub01.diasemi.com, 9
x-kse-antivirus-interceptor-info: scan successful
x-kse-antivirus-info: Clean, bases: 11/11/2016 13:29:00
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uABFoYYo031086
Content-Length: 1416
Lines: 46

On 11 November 2016 10:38, Lee Jones wrote:
> 
> > +static struct resource da9061_core_resources[] = {
> > +	DEFINE_RES_NAMED(DA9061_IRQ_VDD_WARN, 1, "VDD_WARN", IORESOURCE_IRQ),
> > +};
> > +
> > +static struct resource da9061_regulators_resources[] = {
> > +	DEFINE_RES_NAMED(DA9061_IRQ_LDO_LIM, 1, "LDO_LIM", IORESOURCE_IRQ),
> > +};
> > +
> > +static struct resource da9061_thermal_resources[] = {
> > +	DEFINE_RES_NAMED(DA9061_IRQ_TEMP, 1, "THERMAL", IORESOURCE_IRQ),
> > +};
> > +
> > +static struct resource da9061_wdt_resources[] = {
> > +	DEFINE_RES_NAMED(DA9061_IRQ_WDG_WARN, 1, "WD_WARN", IORESOURCE_IRQ),
> > +};
> > +
> > +static struct resource da9061_onkey_resources[] = {
> > +	DEFINE_RES_NAMED(DA9061_IRQ_ONKEY, 1, "ONKEY", IORESOURCE_IRQ),
> > +};
> 
> These should al be: DEFINE_RES_IO_NAMED()

Have altered these to DEFINE_RES_IRQ_NAMED()

> > @@ -142,7 +257,7 @@ static const struct mfd_cell da9062_devs[] = {
> >  		.name		= "da9062-watchdog",
> >  		.num_resources	= ARRAY_SIZE(da9062_wdt_resources),
> >  		.resources	= da9062_wdt_resources,
> > -		.of_compatible  = "dlg,da9062-wdt",
> > +		.of_compatible  = "dlg,da9062-watchdog",
> 
> This should be a separate change.

Ok. reverted.

> > @@ -208,6 +324,7 @@ static int da9062_get_device_type(struct da9062 *chip)
> >  		dev_err(chip->dev, "Cannot read chip ID.\n");
> >  		return -EIO;
> >  	}
> > +
> 
> Sneaky!

Removed the whitespace.