From: Arnd Bergmann <arnd@arndb.de>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Sriram Dash <sriram.dash@nxp.com>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, mathias.nyman@intel.com,
        gregkh@linuxfoundation.org, suresh.gupta@nxp.com,
        stern@rowland.harvard.edu, pku.leo@gmail.com
Subject: Re: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration
Date: Fri, 11 Nov 2016 21:31:09 +0100
Message-ID: <4169621.fqZP0OpVbR@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <87fumzha30.fsf@linux.intel.com>
References: <1478766001-26463-1-git-send-email-sriram.dash@nxp.com> <1478766001-26463-6-git-send-email-sriram.dash@nxp.com> <87fumzha30.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 939
Lines: 22

On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote:
> > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc)
> >  void dwc3_host_exit(struct dwc3 *dwc)
> >  {
> >       phy_remove_lookup(dwc->usb2_generic_phy, "usb2-phy",
> > -                       dev_name(&dwc->xhci->dev));
> > +                       dev_name(dwc->dev));
> >       phy_remove_lookup(dwc->usb3_generic_phy, "usb3-phy",
> > -                       dev_name(&dwc->xhci->dev));
> > +                       dev_name(dwc->dev));
> 
> this looks unrelated to $subject. Care to explain?

bus->sysdev is used for retrieving any information that comes from
the platform (DT or otherwise), and the phy lookup in has to be done
through sysdev as well because the platform cannot add it to
the child device it has no knowledge of.

When we set the sysdev to the parent, the phy lookup has to be
added to that device as well, rather than the child device.

	Arnd