Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965227AbcKKVa0 (ORCPT ); Fri, 11 Nov 2016 16:30:26 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:47234 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935596AbcKKVaY (ORCPT ); Fri, 11 Nov 2016 16:30:24 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 5713761373 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=spjoshi@codeaurora.org Subject: Re: [PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails To: Stephen Boyd References: <1478218237-1737-1-git-send-email-spjoshi@codeaurora.org> <1478218237-1737-4-git-send-email-spjoshi@codeaurora.org> <20161110014908.GZ16026@codeaurora.org> Cc: Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Jordan Crouse , Trilok Soni From: Sarangdhar Joshi Message-ID: <4894fdf2-1253-781d-f177-fff857f60376@codeaurora.org> Date: Fri, 11 Nov 2016 13:30:21 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161110014908.GZ16026@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 28 On 11/09/2016 05:49 PM, Stephen Boyd wrote: > On 11/03, Sarangdhar Joshi wrote: >> When devm_clk_get fails for core clock, the failure was ignored >> and the core_clk was explicitly set to NULL so that other >> remaining clocks can be queried. However, now that we have a >> cleaner way of expressing the clock dependency, return failure >> when devm_clk_get fails for core clock. >> >> Signed-off-by: Sarangdhar Joshi > > Why can't this be folded into the second patch? It seems > incorrect to allow it to silently work in patch 2 even though > we've flagged that clk as a requirement and then change that > behavior here. > The idea was keep it separate so that if someone needs to keep earlier behavior (of ignoring the core clock failure), then it would be easier to just revert this commit and still use flag mechanism. Also convenient with git bisect for finding offending commit. I don't mind squashing this into patch 2 if we think that's better. Regards, Sarang -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project