MIME-Version: 1.0
In-Reply-To: <1478093749-5602-1-git-send-email-jolsa@kernel.org>
References: <1478093749-5602-1-git-send-email-jolsa@kernel.org>
From: Stephane Eranian <eranian@google.com>
Date: Fri, 11 Nov 2016 15:18:03 -0800
Message-ID: <CABPqkBTQw6H=JEZ-crCN=bZduFy+tyLx+voo_7P9n6_7VD5YTg@mail.gmail.com>
Subject: Re: [PATCH 0/3] perf tools: Plug jvmti compilation into perf build
To: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Andi Kleen <andi@firstfloor.org>, William Cohen <wcohen@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1789
Lines: 52

Jiri,

On Wed, Nov 2, 2016 at 6:35 AM, Jiri Olsa <jolsa@kernel.org> wrote:
> hi,
> adding jvmti compilation under perf build, so it's easy
> to put it under rpm.
>
> I plan on updating fedora/rhel perf rpm, to have the jvmti
> placed in like:
>
>   $ rpm -qpl build/x86_64/perf-4.8.5-300.fc24.x86_64.rpm | grep jvmti
>   /usr/lib64/libperf-jvmti.so
>
> Stephane,
> I'm keeping the jvmti/Makefile as I dont fully follow
> the need for .lo objects. Please let me know if you'd
> be ok with this new way of building jvmti lib.
>
Tested the patch on x86_64. With and without NO_JVMTI.
Tried the libperf-jvmti.so on existing test case, got correct results.

I believe you can now remove the jvmti/Makefile, it is not needed
anymore. We must always (and only) build the .so as this library
is meant to be used as a Java agent.

Tested-by: Stephane Eranian <eranian@google.com>

> Also available in:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/fixes
>
> thanks,
> jirla
>
>
> ---
> Jiri Olsa (3):
>       tools build: Add CFLAGS_REMOVE_* support
>       tools build: Add jvmti feature detection support
>       perf tools: Plug jvmti compilation into perf build
>
>  tools/build/Build.include           |  4 +++-
>  tools/build/Documentation/Build.txt |  6 ++++--
>  tools/build/feature/Makefile        |  6 +++++-
>  tools/build/feature/test-jvmti.c    | 13 +++++++++++++
>  tools/perf/Makefile.config          | 26 ++++++++++++++++++++++++++
>  tools/perf/Makefile.perf            | 24 +++++++++++++++++++++++-
>  tools/perf/jvmti/Build              |  8 ++++++++
>  tools/perf/tests/make               |  2 +-
>  8 files changed, 83 insertions(+), 6 deletions(-)
>  create mode 100644 tools/build/feature/test-jvmti.c
>  create mode 100644 tools/perf/jvmti/Build