From: Stuart Yoder <stuart.yoder@nxp.com>
To: Ruxandra Ioana Radulescu <ruxandra.radulescu@nxp.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC: German Rivera <german.rivera@nxp.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "agraf@suse.de" <agraf@suse.de>, "arnd@arndb.de" <arnd@arndb.de>,
        Leo Li <leoyang.li@nxp.com>, Roy Pledge <roy.pledge@nxp.com>,
        Haiying Wang <haiying.wang@nxp.com>
Subject: RE: [PATCH 7/9] bus: fsl-mc: dpio: add the DPAA2 DPIO service
 interface
Thread-Topic: [PATCH 7/9] bus: fsl-mc: dpio: add the DPAA2 DPIO service
 interface
Thread-Index: AQHSK6SWqPs9lCe8r0WaY7CuiHZX+6DHaHfwgAGTcUCACZ8u0A==
Date: Sat, 12 Nov 2016 00:10:31 +0000
Message-ID: <VI1PR0401MB263868A3747B8EC367D193DF8DBA0@VI1PR0401MB2638.eurprd04.prod.outlook.com>
References: <1477058509-12547-1-git-send-email-stuart.yoder@nxp.com>
 <1477058509-12547-8-git-send-email-stuart.yoder@nxp.com>
 <VI1PR0401MB2638B079498EFB89BD8AA5BA8DA30@VI1PR0401MB2638.eurprd04.prod.outlook.com>
 <VI1PR0402MB2847720F20F0EC9371D07ABF94A20@VI1PR0402MB2847.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR0402MB2847720F20F0EC9371D07ABF94A20@VI1PR0402MB2847.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2016 00:10:31.8969
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2638
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAC0QO34000627
Content-Length: 958
Lines: 30

> > +/**
> > + * dpaa2_io_service_rearm() - Rearm the notification for the given DPIO
> > service.
> > + * @service: the given DPIO service.
> > + * @ctx: the notification context.
> > + *
> > + * Once a FQDAN/CDAN has been produced, the corresponding FQ/channel
> > is
> > + * considered "disarmed". Ie. the user can issue pull dequeue operations on
> > that
> > + * traffic source for as long as it likes. Eventually it may wish to "rearm"
> > + * that source to allow it to produce another FQDAN/CDAN, that's what this
> > + * function achieves.
> > + *
> > + * Return 0 for success.
> > + */
> > +int dpaa2_io_service_rearm(struct dpaa2_io *d,
> > +			   struct dpaa2_io_notification_ctx *ctx)
> > +{
> > +	unsigned long irqflags;
> > +	int err;
> > +
> > +	d = service_select(d);
> 
> Why not select the DPIO based on ctx->desired_cpu, like in the initial
> notification register?

Sounds like a reasonable idea, I am going to confirm with Roy.

Stuart