Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756892AbcKLEWg (ORCPT ); Fri, 11 Nov 2016 23:22:36 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:36295 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756727AbcKLEWe (ORCPT ); Fri, 11 Nov 2016 23:22:34 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 220.200.4.109 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 1/9] arm64: dts: rockchip: add eMMC's power domain support for rk3399 To: Caesar Wang , Heiko Stuebner References: <1478697721-2323-1-git-send-email-wxt@rock-chips.com> <1478697721-2323-2-git-send-email-wxt@rock-chips.com> Cc: shawn.lin@rock-chips.com, Mark Rutland , devicetree@vger.kernel.org, Elaine Zhang , Catalin Marinas , Brian Norris , Ziyuan Xu , Will Deacon , Douglas Anderson , Rob Herring , tfiga@chromium.org, linux-rockchip@lists.infradead.org, eddie.cai@rock-chips.com, linux-arm-kernel@lists.infradead.org, David Wu , Jianqun Xu , linux-kernel@vger.kernel.org From: Shawn Lin Message-ID: Date: Sat, 12 Nov 2016 12:22:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478697721-2323-2-git-send-email-wxt@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1814 Lines: 68 On 2016/11/9 21:21, Caesar Wang wrote: > From: Ziyuan Xu > > Control power domain for eMMC via genpd to reduce power consumption. > > Signed-off-by: Elaine Zhang > Signed-off-by: Ziyuan Xu > Signed-off-by: Caesar Wang It was verified on my rk3399 evb with kernel4.4, so free feel to add my tag, Tested-by: Shawn Lin BTW, it seems my reply is bounced form Yakir's address, so please remove him from CC list if he changed his mail address. > --- > > Changes in v2: > - Reviewed-on: https://chromium-review.googlesource.com/376558 > - Verified on ChromeOS kernel4.4 > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index cbb7f8b..b401176 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -269,6 +269,7 @@ > #clock-cells = <0>; > phys = <&emmc_phy>; > phy-names = "phy_arasan"; > + power-domains = <&power RK3399_PD_EMMC>; > status = "disabled"; > }; > > @@ -690,6 +691,11 @@ > status = "disabled"; > }; > > + qos_emmc: qos@ffa58000 { > + compatible = "syscon"; > + reg = <0x0 0xffa58000 0x0 0x20>; > + }; > + > qos_gmac: qos@ffa5c000 { > compatible = "syscon"; > reg = <0x0 0xffa5c000 0x0 0x20>; > @@ -823,6 +829,11 @@ > }; > > /* These power domains are grouped by VD_LOGIC */ > + pd_emmc@RK3399_PD_EMMC { > + reg = ; > + clocks = <&cru ACLK_EMMC>; > + pm_qos = <&qos_emmc>; > + }; > pd_gmac@RK3399_PD_GMAC { > reg = ; > clocks = <&cru ACLK_GMAC>; > -- Best Regards Shawn Lin