Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966380AbcKLOdm (ORCPT ); Sat, 12 Nov 2016 09:33:42 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:55302 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S938797AbcKLOdk (ORCPT ); Sat, 12 Nov 2016 09:33:40 -0500 Subject: Re: [PATCH v2 2/2] arm64: dts: Add ARM PMU node for exynos7 To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <1478945832-1826-1-git-send-email-alim.akhtar@samsung.com> <1478945832-1826-2-git-send-email-alim.akhtar@samsung.com> From: Javier Martinez Canillas Cc: krzk@kernel.org, will.deacon@arm.com, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, robin.murphy@arm.com Message-ID: <9327f863-7fa3-a967-892c-67158b2471a9@osg.samsung.com> Date: Sat, 12 Nov 2016 11:33:18 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1478945832-1826-2-git-send-email-alim.akhtar@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1510 Lines: 45 Hello Alim, On 11/12/2016 07:17 AM, Alim Akhtar wrote: > This patch adds ARM Performance Monitor Unit dt node for exynos7. > PMU provides various statistics on the operation of the CPU and > memory system at runtime, which are very useful when debugging or > profiling code. This enables the same. > > Signed-off-by: Alim Akhtar > --- > arch/arm64/boot/dts/exynos/exynos7.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > Changes since v1: > * Added "interrupt-affinity" property as per Robin Murphy review comment. > > diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi > index 396ffb9..09e7a05b 100644 > --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi > @@ -472,6 +472,16 @@ > status = "disabled"; > }; > > + arm-pmu { > + compatible = "arm,cortex-a57-pmu", "arm,armv8-pmuv3"; > + interrupts = , > + , > + , > + ; > + interrupt-affinity = <&cpu_atlas0>, <&cpu_atlas1>, > + <&cpu_atlas2>, <&cpu_atlas3>; > + }; > + I didn't double check if these are the correct IRQs because I don't have an Exynos7 user manual, but the change looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America