Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966747AbcKLSAU (ORCPT ); Sat, 12 Nov 2016 13:00:20 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:47306 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966701AbcKLSAD (ORCPT ); Sat, 12 Nov 2016 13:00:03 -0500 X-IronPort-AV: E=Sophos;i="5.31,480,1473112800"; d="scan'208";a="244730418" Date: Sat, 12 Nov 2016 18:59:55 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Vaishali Thakkar cc: mmarek@suse.com, julia.lawall@lip6.fr, gilles.muller@lip6.fr, nicolas.palix@imag.fr, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, lars@metafoo.de Subject: Re: [PATCH v3 3/3] Coccinelle: misc: Add support for devm variant in all modes In-Reply-To: <66e8233a1bb85a93ea70815dbc3416c2cc9edd5c.1477293469.git.vaishali.thakkar@oracle.com> Message-ID: References: <66e8233a1bb85a93ea70815dbc3416c2cc9edd5c.1477293469.git.vaishali.thakkar@oracle.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1631 Lines: 68 On Mon, 24 Oct 2016, Vaishali Thakkar wrote: > Add missing support for the devm_request_threaded_irq in > the rules of context, report and org modes. > > Misc: > ---- > To be consistent with other scripts, change confidence level > of the script to 'Moderate'. > > Signed-off-by: Vaishali Thakkar Acked-by: Julia Lawall > --- > Changes since v2: > - Add missing initialization of metavariables > Changes since v1: > - Split patch in to the patchset > --- > scripts/coccinelle/misc/irqf_oneshot.cocci | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci > index e53372e..ca78125 100644 > --- a/scripts/coccinelle/misc/irqf_oneshot.cocci > +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci > @@ -5,7 +5,7 @@ > /// So pass the IRQF_ONESHOT flag in this case. > /// > // > -// Confidence: Good > +// Confidence: Moderate > // Comments: > // Options: --no-includes > > @@ -87,16 +87,26 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, > ) > > @depends on context@ > +expression dev; > expression irq; > position p != {r1.p,r2.p}; > @@ > +( > *request_threaded_irq@p(irq, NULL, ...) > +| > +*devm_request_threaded_irq@p(dev, irq, NULL, ...) > +) > > @match depends on report || org@ > +expression dev; > expression irq; > position p != {r1.p,r2.p}; > @@ > +( > request_threaded_irq@p(irq, NULL, ...) > +| > +devm_request_threaded_irq@p(dev, irq, NULL, ...) > +) > > @script:python depends on org@ > p << match.p; > -- > 2.1.4 > >