Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966732AbcKLSBp (ORCPT ); Sat, 12 Nov 2016 13:01:45 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:35577 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966530AbcKLSBo (ORCPT ); Sat, 12 Nov 2016 13:01:44 -0500 X-IronPort-AV: E=Sophos;i="5.31,480,1473112800"; d="scan'208";a="200132270" Date: Sat, 12 Nov 2016 19:01:17 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Vaishali Thakkar cc: mmarek@suse.com, julia.lawall@lip6.fr, gilles.muller@lip6.fr, nicolas.palix@imag.fr, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, lars@metafoo.de Subject: Re: [PATCH v3 2/3] Coccinelle: misc: Improve the result given by context mode In-Reply-To: <684296c10e1e8861ac7294cbb1e3d2618bb2c233.1477293469.git.vaishali.thakkar@oracle.com> Message-ID: References: <684296c10e1e8861ac7294cbb1e3d2618bb2c233.1477293469.git.vaishali.thakkar@oracle.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 38 On Mon, 24 Oct 2016, Vaishali Thakkar wrote: > To eliminate false positives given by the context mode, add > necessary arguments for the function request_threaded_irq. > > Signed-off-by: Vaishali Thakkar Acked-by: Julia Lawall > --- > Changes since v2: > - Add missing declaration of metavariable irq > Changes since v1: > - Split patch in to the patch set > --- > scripts/coccinelle/misc/irqf_oneshot.cocci | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci > index a8537fb..e53372e 100644 > --- a/scripts/coccinelle/misc/irqf_oneshot.cocci > +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci > @@ -87,9 +87,10 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, > ) > > @depends on context@ > +expression irq; > position p != {r1.p,r2.p}; > @@ > -*request_threaded_irq@p(...) > +*request_threaded_irq@p(irq, NULL, ...) > > @match depends on report || org@ > expression irq; > -- > 2.1.4 > >