Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932427AbcKLV4C (ORCPT ); Sat, 12 Nov 2016 16:56:02 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33538 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753832AbcKLV4A (ORCPT ); Sat, 12 Nov 2016 16:56:00 -0500 Subject: Re: [PATCH 2/3] mtd: use min_t() to refactor mtd_ooblayout_{get, set}_bytes() To: Masahiro Yamada , linux-mtd@lists.infradead.org References: <1478657290-9430-1-git-send-email-yamada.masahiro@socionext.com> <1478657290-9430-3-git-send-email-yamada.masahiro@socionext.com> Cc: Boris Brezillon , Richard Weinberger , linux-kernel@vger.kernel.org, Cyrille Pitchen , Brian Norris , David Woodhouse From: Marek Vasut Message-ID: Date: Sat, 12 Nov 2016 22:27:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478657290-9430-3-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 40 On 11/09/2016 03:08 AM, Masahiro Yamada wrote: > I hope this will make the code a little more readable. > > Signed-off-by: Masahiro Yamada Reviewed-by: Marek Vasut > --- > > drivers/mtd/mtdcore.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index cf85f2b..ca6a89a 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -1283,7 +1283,7 @@ static int mtd_ooblayout_get_bytes(struct mtd_info *mtd, u8 *buf, > while (!ret) { > int cnt; > > - cnt = oobregion.length > nbytes ? nbytes : oobregion.length; > + cnt = min_t(int, nbytes, oobregion.length); > memcpy(buf, oobbuf + oobregion.offset, cnt); > buf += cnt; > nbytes -= cnt; > @@ -1326,7 +1326,7 @@ static int mtd_ooblayout_set_bytes(struct mtd_info *mtd, const u8 *buf, > while (!ret) { > int cnt; > > - cnt = oobregion.length > nbytes ? nbytes : oobregion.length; > + cnt = min_t(int, nbytes, oobregion.length); > memcpy(oobbuf + oobregion.offset, buf, cnt); > buf += cnt; > nbytes -= cnt; > -- Best regards, Marek Vasut