Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933326AbcKLV5O (ORCPT ); Sat, 12 Nov 2016 16:57:14 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34380 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754207AbcKLV4P (ORCPT ); Sat, 12 Nov 2016 16:56:15 -0500 Subject: Re: [PATCH 05/11] mtd: nand: denali: remove "Spectra:" prefix from printk strings To: Masahiro Yamada , linux-mtd@lists.infradead.org References: <1478666130-13413-1-git-send-email-yamada.masahiro@socionext.com> <1478666130-13413-6-git-send-email-yamada.masahiro@socionext.com> Cc: Alan Cox , David Woodhouse , Jason Roberts , Chuanxiao Dong , Dinh Nguyen , linux-kernel@vger.kernel.org, Boris Brezillon , Brian Norris , Richard Weinberger , David Woodhouse , Cyrille Pitchen From: Marek Vasut Message-ID: <5a1b5ef5-5c1a-ce20-f0be-ed6abed6996e@gmail.com> Date: Sat, 12 Nov 2016 22:35:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478666130-13413-6-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2882 Lines: 86 On 11/09/2016 05:35 AM, Masahiro Yamada wrote: > As far as I understood from the Kconfig menu deleted by commit > be7f39c5ecf5 ("Staging: delete spectra driver"), the "Spectra" is > specific to Intel Moorestown Platform. > > The Denali NAND controller IP is used for various SoCs such as > Altera SOCFPGA, Socionext UniPhier, etc. The platform specific > strings are not preferred in this driver. > > Signed-off-by: Masahiro Yamada Reviewed-by: Marek Vasut > --- > > As an ARM-SoC developer, I only need denali.c and denali_dt.c. > > I see some "Spectra:" in drivers/mtd/nand/denali_pci.c as well. > I was not quite sure if they are needed or not. > If desired, I can update this patch to remove them too. Is anyone even using Denali on Intel now ? > drivers/mtd/nand/denali.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c > index 80d3e26..78d795b 100644 > --- a/drivers/mtd/nand/denali.c > +++ b/drivers/mtd/nand/denali.c > @@ -402,7 +402,7 @@ static void get_hynix_nand_para(struct denali_nand_info *denali, > break; > default: > dev_warn(denali->dev, > - "Spectra: Unknown Hynix NAND (Device ID: 0x%x).\n" > + "Unknown Hynix NAND (Device ID: 0x%x).\n" > "Will use default parameter values instead.\n", > device_id); > } > @@ -1458,7 +1458,7 @@ int denali_init(struct denali_nand_info *denali) > */ > if (request_irq(denali->irq, denali_isr, IRQF_SHARED, > DENALI_NAND_NAME, denali)) { > - pr_err("Spectra: Unable to allocate IRQ\n"); > + dev_err(denali->dev, "Unable to request IRQ\n"); > return -ENODEV; > } > > @@ -1495,7 +1495,7 @@ int denali_init(struct denali_nand_info *denali) > /* Is 32-bit DMA supported? */ > ret = dma_set_mask(denali->dev, DMA_BIT_MASK(32)); > if (ret) { > - pr_err("Spectra: no usable DMA configuration\n"); > + dev_err(denali->dev, "no usable DMA configuration\n"); > goto failed_req_irq; > } > > @@ -1503,7 +1503,7 @@ int denali_init(struct denali_nand_info *denali) > mtd->writesize + mtd->oobsize, > DMA_BIDIRECTIONAL); > if (dma_mapping_error(denali->dev, denali->buf.dma_buf)) { > - dev_err(denali->dev, "Spectra: failed to map DMA buffer\n"); > + dev_err(denali->dev, "failed to map DMA buffer\n"); Nit: For consistency's sake, use Failed with capital F . Fix the "No usable DMA ..." too. > ret = -EIO; > goto failed_req_irq; > } > @@ -1598,8 +1598,7 @@ int denali_init(struct denali_nand_info *denali) > > ret = mtd_device_register(mtd, NULL, 0); > if (ret) { > - dev_err(denali->dev, "Spectra: Failed to register MTD: %d\n", > - ret); > + dev_err(denali->dev, "Failed to register MTD: %d\n", ret); > goto failed_req_irq; > } > return 0; > -- Best regards, Marek Vasut