Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934858AbcKMSko (ORCPT ); Sun, 13 Nov 2016 13:40:44 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:45192 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932803AbcKMSkn (ORCPT ); Sun, 13 Nov 2016 13:40:43 -0500 Date: Sun, 13 Nov 2016 13:40:40 -0500 (EST) Message-Id: <20161113.134040.2130627876291744441.davem@davemloft.net> To: ivan.khoronzhuk@linaro.org Cc: mugunthanvnm@ti.com, grygorii.strashko@ti.com, netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: ethernet: ti: davinci_cpdma: fix fixed prio cpdma ctlr configuration From: David Miller In-Reply-To: <1478871924-20985-1-git-send-email-ivan.khoronzhuk@linaro.org> References: <1478871924-20985-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 13 Nov 2016 09:41:12 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 558 Lines: 13 From: Ivan Khoronzhuk Date: Fri, 11 Nov 2016 15:45:24 +0200 > The dma ctlr is reseted to 0 while cpdma soft reset, thus cpdma ctlr > cannot be configured after cpdma is stopped. So restoring content > of cpdma ctlr while off/on procedure is needed. The cpdma ctlr off/on > procedure is present while interface down/up and while changing number > of channels with ethtool. In order to not restore content in many > places, move it to cpdma_ctlr_start(). > > Signed-off-by: Ivan Khoronzhuk Applied.