Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964928AbcKMWUJ (ORCPT ); Sun, 13 Nov 2016 17:20:09 -0500 Received: from mail1.windriver.com ([147.11.146.13]:63179 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964868AbcKMWUG (ORCPT ); Sun, 13 Nov 2016 17:20:06 -0500 From: Paul Gortmaker To: CC: Paul Gortmaker , Alexandre Courbot , Arnd Bergmann , Maxime Ripard , Scott Wood , Stephen Warren , Thierry Reding , Ulf Hansson , Yangbo Lu , , , Subject: [PATCH 0/3] soc: avoid module usage in non-modular code Date: Sun, 13 Nov 2016 14:02:59 -0500 Message-ID: <20161113190302.18099-1-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.10.1 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1966 Lines: 50 This series of commits is a part of a larger project to ensure people don't reference modular support functions in non-modular code. Overall there was roughly 5k lines of dead code in the kernel due to this. So far we've fixed several areas, like tty, x86, net, gpio ... and we continue to work on other areas. There are several reasons to not use module support for code that can never be built as a module, but the big ones are: (1) it is easy to accidentally code up unused module_exit and remove code (2) it can be misleading when reading the source, thinking it can be modular when the Makefile and/or Kconfig prohibit it (3) it requires the include of the module.h header file which in turn includes nearly everything else. Two of the changes are essentially source only -- the resuting module will be binary equivalent. Only the FSL driver has unused code in addition to the use of modular macros that get converted. Note the FSL SOC driver just appeared in linux-next and so this series won't apply on Linus' master branch. These commits were applied to linux-next and build tested there. Paul. --- Cc: Alexandre Courbot Cc: Arnd Bergmann Cc: Maxime Ripard Cc: Scott Wood Cc: Stephen Warren Cc: Thierry Reding Cc: Ulf Hansson Cc: Yangbo Lu Cc: linux-arm-kernel@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-tegra@vger.kernel.org Paul Gortmaker (3): soc: sunxi: make sunxi_sram explicitly non-modular soc: tegra: make fuse-tegra explicitly non-modular soc: fsl: make guts driver explicitly non-modular drivers/soc/fsl/guts.c | 17 ++--------------- drivers/soc/sunxi/sunxi_sram.c | 9 ++------- drivers/soc/tegra/fuse/fuse-tegra.c | 4 ++-- 3 files changed, 6 insertions(+), 24 deletions(-) -- 2.10.1