Date: Mon, 14 Nov 2016 09:51:14 +0800
From: Peter Chen <hzpeterchen@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
        Sriram Dash <sriram.dash@nxp.com>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, mathias.nyman@intel.com,
        gregkh@linuxfoundation.org, suresh.gupta@nxp.com,
        stern@rowland.harvard.edu, pku.leo@gmail.com
Subject: Re: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration
Message-ID: <20161114015114.GA7635@b29397-desktop>
References: <1478766001-26463-1-git-send-email-sriram.dash@nxp.com>
 <1478766001-26463-6-git-send-email-sriram.dash@nxp.com>
 <87fumzha30.fsf@linux.intel.com>
 <4169621.fqZP0OpVbR@wuerfel>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4169621.fqZP0OpVbR@wuerfel>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1173
Lines: 30

On Fri, Nov 11, 2016 at 09:31:09PM +0100, Arnd Bergmann wrote:
> On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote:
> > > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc)
> > >  void dwc3_host_exit(struct dwc3 *dwc)
> > >  {
> > >       phy_remove_lookup(dwc->usb2_generic_phy, "usb2-phy",
> > > -                       dev_name(&dwc->xhci->dev));
> > > +                       dev_name(dwc->dev));
> > >       phy_remove_lookup(dwc->usb3_generic_phy, "usb3-phy",
> > > -                       dev_name(&dwc->xhci->dev));
> > > +                       dev_name(dwc->dev));
> > 
> > this looks unrelated to $subject. Care to explain?
> 
> bus->sysdev is used for retrieving any information that comes from
> the platform (DT or otherwise), and the phy lookup in has to be done
> through sysdev as well because the platform cannot add it to
> the child device it has no knowledge of.
> 
> When we set the sysdev to the parent, the phy lookup has to be
> added to that device as well, rather than the child device.
> 

Then, the device should change to dwc->sysdev, and phy_create_lookup
in this file needs to change too.

-- 

Best Regards,
Peter Chen