Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933447AbcKNDCa (ORCPT ); Sun, 13 Nov 2016 22:02:30 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:47094 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752603AbcKNCXZ (ORCPT ); Sun, 13 Nov 2016 21:23:25 -0500 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Peter Zijlstra" , "David Howells" , "Thomas Gleixner" , "Stephan Mueller" , "Andy Lutomirski" , "H. Peter Anvin" , "Denys Vlasenko" , "Ingo Molnar" , linux-security-module@vger.kernel.org, "Josh Poimboeuf" , "Linus Torvalds" , keyrings@vger.kernel.org, "Borislav Petkov" , "Brian Gerst" Date: Mon, 14 Nov 2016 00:14:07 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.2 051/152] x86/syscalls/64: Add compat_sys_keyctl for 32-bit userspace In-Reply-To: X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1535 Lines: 42 3.2.84-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: David Howells commit f7d665627e103e82d34306c7d3f6f46f387c0d8b upstream. x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than calling sys_keyctl(). The latter will work in a lot of cases, thereby hiding the issue. Reported-by: Stephan Mueller Tested-by: Stephan Mueller Signed-off-by: David Howells Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Josh Poimboeuf Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: keyrings@vger.kernel.org Cc: linux-security-module@vger.kernel.org Link: http://lkml.kernel.org/r/146961615805.14395.5581949237156769439.stgit@warthog.procyon.org.uk Signed-off-by: Ingo Molnar [bwh: Backported to 3.2: compat system call table is in ia32entry.S] Signed-off-by: Ben Hutchings --- --- a/arch/x86/ia32/ia32entry.S +++ b/arch/x86/ia32/ia32entry.S @@ -791,7 +791,7 @@ ia32_sys_call_table: .quad quiet_ni_syscall /* 285: sys_altroot */ .quad sys_add_key .quad sys_request_key - .quad sys_keyctl + .quad compat_sys_keyctl .quad sys_ioprio_set .quad sys_ioprio_get /* 290 */ .quad sys_inotify_init