Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264233AbTEGVTJ (ORCPT ); Wed, 7 May 2003 17:19:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264242AbTEGVTJ (ORCPT ); Wed, 7 May 2003 17:19:09 -0400 Received: from air-2.osdl.org ([65.172.181.6]:28808 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S264233AbTEGVTH (ORCPT ); Wed, 7 May 2003 17:19:07 -0400 Date: Wed, 7 May 2003 14:27:59 -0700 From: "Randy.Dunlap" To: Marcus Alanen Cc: jgarzik@pobox.com, linux-kernel@vger.kernel.org Subject: Re: top stack (l)users for 2.5.69 Message-Id: <20030507142759.6f93e589.rddunlap@osdl.org> In-Reply-To: <200305072127.h47LR1Z14629@infa.abo.fi> References: <3EB95BD7.8060700@pobox.com> <20030507132024.GB18177@wohnheim.fh-wedel.de> <1052332566.752437@palladium.transmeta.com> <3EB95BD7.8060700@pobox.com> <20030507133856.02748f4e.rddunlap@osdl.org> <200305072127.h47LR1Z14629@infa.abo.fi> Organization: OSDL X-Mailer: Sylpheed version 0.8.11 (GTK+ 1.2.10; i586-pc-linux-gnu) X-Face: +5V?h'hZQPB9kW Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 25 On Thu, 8 May 2003 00:27:01 +0300 Marcus Alanen wrote: | On Wed, 7 May 2003 13:38:56 -0700, Randy.Dunlap wrote: | >I have mostly used kmalloc/kfree, but using automatic variables is certainly | >cleaner to write (code). One of the patches that I did just made each ioctl | >cmd call a separate function, and then each separate function was able to use | >automatic variables on the stack instead of kmalloc/kfree. I prefer this | >method when it's feasible (and until gcc can handle these cases). | | I take it moving the automatic variables in the function to a static | data area would be possible, _if_ that function (or rather, the | variables) is protected by some unique lock (not some per-structure | lock, of course)? Although this is probably already done in the | majority of cases. Sure, it just means that use of those areas has to be serialized, whereas the other ways allow reentrant/concurrent uses. -- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/