Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966024AbcKNENl (ORCPT ); Sun, 13 Nov 2016 23:13:41 -0500 Received: from mail-pf0-f181.google.com ([209.85.192.181]:34195 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965818AbcKNENk (ORCPT ); Sun, 13 Nov 2016 23:13:40 -0500 Date: Mon, 14 Nov 2016 09:36:22 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Rafael Wysocki , Ingo Molnar , Peter Zijlstra , Lists linaro-kernel , Linux PM , Linux Kernel Mailing List , Vincent Guittot , Juri Lelli , Robin Randhawa Subject: Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier Message-ID: <20161114040622.GA29087@vireshk-i7> References: <1acfffe798c0371e69ec1171f485499e7b49ed6d.1478858983.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 567 Lines: 17 On 13-11-16, 15:46, Rafael J. Wysocki wrote: > That's only going to happen in the next patch, though, right? It > wouldn't hurt to write that in the changelog too. Sure. > Besides, I'm not actually sure if starting/stopping the kthread in > sugov_policy_alloc/free() is a good idea. It sort of conflates the > allocation of memory with kthread creation. Any chance to untangle > that? Hmm, so either I can create two new routines for the thread and call them along with alloc/free. Or I can rename the alloc/free routines and keep this patch as is. -- viresh