From: Sriram Dash <sriram.dash@nxp.com>
To: Peter Chen <hzpeterchen@gmail.com>, Arnd Bergmann <arnd@arndb.de>
CC: Felipe Balbi <felipe.balbi@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "mathias.nyman@intel.com" <mathias.nyman@intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Suresh Gupta <suresh.gupta@nxp.com>,
        "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
        "pku.leo@gmail.com" <pku.leo@gmail.com>
Subject: RE: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration
Thread-Topic: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration
Thread-Index: AQHSOyuYgUZA43dYKEumlkcpOtoRj6DSDW6AgAIxTICAA34YAIAAMMMQ
Date: Mon, 14 Nov 2016 04:46:35 +0000
Message-ID: <DB5PR0401MB1925E0CF1B6C9780A0E5DE60F5BC0@DB5PR0401MB1925.eurprd04.prod.outlook.com>
References: <1478766001-26463-1-git-send-email-sriram.dash@nxp.com>
 <1478766001-26463-6-git-send-email-sriram.dash@nxp.com>
 <87fumzha30.fsf@linux.intel.com> <4169621.fqZP0OpVbR@wuerfel>
 <20161114015114.GA7635@b29397-desktop>
In-Reply-To: <20161114015114.GA7635@b29397-desktop>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2016 04:46:35.8665
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1351
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAE5KN3C012704
Content-Length: 1271
Lines: 33

>From: Peter Chen [mailto:hzpeterchen@gmail.com]
>On Fri, Nov 11, 2016 at 09:31:09PM +0100, Arnd Bergmann wrote:
>> On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote:
>> > > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc)  void
>> > > dwc3_host_exit(struct dwc3 *dwc)  {
>> > >       phy_remove_lookup(dwc->usb2_generic_phy, "usb2-phy",
>> > > -                       dev_name(&dwc->xhci->dev));
>> > > +                       dev_name(dwc->dev));
>> > >       phy_remove_lookup(dwc->usb3_generic_phy, "usb3-phy",
>> > > -                       dev_name(&dwc->xhci->dev));
>> > > +                       dev_name(dwc->dev));
>> >
>> > this looks unrelated to $subject. Care to explain?
>>
>> bus->sysdev is used for retrieving any information that comes from
>> the platform (DT or otherwise), and the phy lookup in has to be done
>> through sysdev as well because the platform cannot add it to the child
>> device it has no knowledge of.
>>
>> When we set the sysdev to the parent, the phy lookup has to be added
>> to that device as well, rather than the child device.
>>
>
>Then, the device should change to dwc->sysdev, and phy_create_lookup in this file
>needs to change too.
>

Yes Peter. I agree to that. 

>--
>
>Best Regards,
>Peter Chen