Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755487AbcKNFUE (ORCPT ); Mon, 14 Nov 2016 00:20:04 -0500 Received: from mail-db5eur01on0088.outbound.protection.outlook.com ([104.47.2.88]:13536 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752196AbcKNFUC (ORCPT ); Mon, 14 Nov 2016 00:20:02 -0500 From: Sriram Dash To: Peter Chen , Arnd Bergmann CC: Felipe Balbi , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "mathias.nyman@intel.com" , "gregkh@linuxfoundation.org" , Suresh Gupta , "stern@rowland.harvard.edu" , "pku.leo@gmail.com" Subject: RE: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration Thread-Topic: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration Thread-Index: AQHSOyuYgUZA43dYKEumlkcpOtoRj6DSDW6AgAIxTICAA34YAIAAMMMQ Date: Mon, 14 Nov 2016 04:46:35 +0000 Message-ID: References: <1478766001-26463-1-git-send-email-sriram.dash@nxp.com> <1478766001-26463-6-git-send-email-sriram.dash@nxp.com> <87fumzha30.fsf@linux.intel.com> <4169621.fqZP0OpVbR@wuerfel> <20161114015114.GA7635@b29397-desktop> In-Reply-To: <20161114015114.GA7635@b29397-desktop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sriram.dash@nxp.com; x-originating-ip: [192.88.169.1] x-microsoft-exchange-diagnostics: 1;DB5PR04MB1351;7:wN9vvM3Zys+y8QAPD+25uxhSFQOeX8OCnADi34yzP63pD/M6T72KWDkgyVqb+zQXbOYvUJabU6ezZjW4Cr9FHlzPTlRZInm+V71iBip8lwFygs6c7ToibxTiV+wpxl3M5vGwinHX4TSxThehKU3BrWOIQZcViYW8tpCmOxOcJ2KUrMZCbsHZ/iJnt4u6z5laejZ96L2BlH9WINY1qj0kwQkMsjx80QS591YroiRQqWq6uPYpwhL94I8QOZq51wSm/1+Q6GV0CmFDIApmoNKJoSTqdlJUXlIvS2aBMRk6lKEWl/PiKbsUnf8IWfbLdI0/FtCpGP/HoPx8QcXBgNqZujzr37QFK48zjC7XtHgq1lc= x-ms-office365-filtering-correlation-id: b9f2b1c0-e20b-4780-aae4-08d40c4936e8 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB5PR04MB1351; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6045074)(6060319)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6061314)(6046074);SRVR:DB5PR04MB1351;BCL:0;PCL:0;RULEID:;SRVR:DB5PR04MB1351; x-forefront-prvs: 0126A32F74 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(336003)(377454003)(189002)(199003)(24454002)(105586002)(106356001)(106116001)(4326007)(2906002)(97736004)(5001770100001)(2950100002)(86362001)(76576001)(229853002)(74316002)(8936002)(7736002)(93886004)(9686002)(305945005)(7846002)(68736007)(50986999)(54356999)(87936001)(76176999)(81166006)(81156014)(7696004)(8676002)(102836003)(3846002)(5660300001)(2900100001)(92566002)(3660700001)(6116002)(586003)(3280700002)(189998001)(122556002)(66066001)(77096005)(101416001)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR04MB1351;H:DB5PR0401MB1925.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2016 04:46:35.8665 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1351 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAE5KN3C012704 Content-Length: 1271 Lines: 33 >From: Peter Chen [mailto:hzpeterchen@gmail.com] >On Fri, Nov 11, 2016 at 09:31:09PM +0100, Arnd Bergmann wrote: >> On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote: >> > > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc) void >> > > dwc3_host_exit(struct dwc3 *dwc) { >> > > phy_remove_lookup(dwc->usb2_generic_phy, "usb2-phy", >> > > - dev_name(&dwc->xhci->dev)); >> > > + dev_name(dwc->dev)); >> > > phy_remove_lookup(dwc->usb3_generic_phy, "usb3-phy", >> > > - dev_name(&dwc->xhci->dev)); >> > > + dev_name(dwc->dev)); >> > >> > this looks unrelated to $subject. Care to explain? >> >> bus->sysdev is used for retrieving any information that comes from >> the platform (DT or otherwise), and the phy lookup in has to be done >> through sysdev as well because the platform cannot add it to the child >> device it has no knowledge of. >> >> When we set the sysdev to the parent, the phy lookup has to be added >> to that device as well, rather than the child device. >> > >Then, the device should change to dwc->sysdev, and phy_create_lookup in this file >needs to change too. > Yes Peter. I agree to that. >-- > >Best Regards, >Peter Chen