Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755197AbcKNGq7 (ORCPT ); Mon, 14 Nov 2016 01:46:59 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36169 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754188AbcKNGq6 (ORCPT ); Mon, 14 Nov 2016 01:46:58 -0500 Date: Mon, 14 Nov 2016 07:46:03 +0100 From: Daniel Vetter To: Andrew Donnellan Cc: airlied@gmail.com, dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths Message-ID: <20161114064602.gag5lrwlrrbmqebw@phenom.ffwll.local> Mail-Followup-To: Andrew Donnellan , airlied@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20161114030359.27852-1-andrew.donnellan@au1.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161114030359.27852-1-andrew.donnellan@au1.ibm.com> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: NeoMutt/20161104 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 40 On Mon, Nov 14, 2016 at 02:03:59PM +1100, Andrew Donnellan wrote: > In the err_free_vram and err_release_fbi error paths in astfb_create(), we > attempt to free afbdev->sysram. The only jumps to these error paths occur > before we assign afbdev->sysram = sysram. Free sysram instead. > > Signed-off-by: Andrew Donnellan Applied to drm-misc, thanks. -Daniel > > --- > > Found by Coverity Scan. Compile tested only. > --- > drivers/gpu/drm/ast/ast_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c > index 7a86e24..d6f5ec6 100644 > --- a/drivers/gpu/drm/ast/ast_fb.c > +++ b/drivers/gpu/drm/ast/ast_fb.c > @@ -253,7 +253,7 @@ static int astfb_create(struct drm_fb_helper *helper, > err_release_fbi: > drm_fb_helper_release_fbi(helper); > err_free_vram: > - vfree(afbdev->sysram); > + vfree(sysram); > return ret; > } > > -- > Andrew Donnellan OzLabs, ADL Canberra > andrew.donnellan@au1.ibm.com IBM Australia Limited > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch