Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754305AbcKNIKq (ORCPT ); Mon, 14 Nov 2016 03:10:46 -0500 Received: from mx2.suse.de ([195.135.220.15]:47073 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753618AbcKNIKp (ORCPT ); Mon, 14 Nov 2016 03:10:45 -0500 Date: Mon, 14 Nov 2016 09:10:15 +0100 From: Johannes Thumshirn To: Arnd Bergmann Cc: Jens Axboe , Christoph Hellwig , Ming Lin , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] skd: fix function prototype Message-ID: <20161114081015.cpjnxdx6yarad74r@linux-x5ow.site> References: <20161109125555.1440353-1-arnd@arndb.de> <20161109125555.1440353-2-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161109125555.1440353-2-arnd@arndb.de> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 20 On Wed, Nov 09, 2016 at 01:55:35PM +0100, Arnd Bergmann wrote: > Building with W=1 shows a harmless warning for the skd driver: > > drivers/block/skd_main.c:2959:1: error: ‘static’ is not at beginning of declaration [-Werror=old-style-declaration] > > This changes the prototype to the expected formatting. > > Signed-off-by: Arnd Bergmann > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850