Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932942AbcKNIqr (ORCPT ); Mon, 14 Nov 2016 03:46:47 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36265 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbcKNIqn (ORCPT ); Mon, 14 Nov 2016 03:46:43 -0500 Subject: Re: [PATCH v2 0/7] perf config: Add support for config read/write To: Arnaldo Carvalho de Melo References: <1479111702-5989-1-git-send-email-treeze.taeung@gmail.com> Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Wang Nan From: Taeung Song Message-ID: Date: Mon, 14 Nov 2016 17:46:38 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1479111702-5989-1-git-send-email-treeze.taeung@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1836 Lines: 56 Hi, Arnaldo :) I guess you're so busy, but would you mind If I ask a question ? I sent a patchset adding support for config read/write. (There are also Namhyung's demand lately https://lkml.org/lkml/2016/10/24/572) For a while, I stoped the patchset about default config array https://lkml.org/lkml/2016/9/5/17 . Is it better to handle support for config reade/write, first ? Thanks, Taeung On 11/14/2016 05:21 PM, Taeung Song wrote: > Hello, :) > > Add simple config read/write functionalities. > > I had worked at the related patchset https://lkml.org/lkml/2016/2/22/38 > But I remake new this patchset for only support for read/write config file. > And There're Namhyung's requests https://lkml.org/lkml/2016/10/24/572 > > In particular, I agonized implement way for write functionality. > I especially wonder other opinions about new boolean variable > 'from_system_config' I use. > > If someone review this patchset and give me some feedback, > I'd appreciated it. :) > > Thanks, > Taeung > > v2: > - a bit change commit messages > - refactor parts of parse_config_arg > > Taeung Song (7): > perf config: Add support for getting functionality > perf config: Document examples getting config info in man page > perf config: Parse arguments before getting functionality > perf config: Parse arguments before setting functionality > perf config: Add support for write functionality > perf config: Document config setting examples in man page > perf config: Mark where are config items from (user or system) > > tools/perf/Documentation/perf-config.txt | 35 +++++++ > tools/perf/builtin-config.c | 155 ++++++++++++++++++++++++++++++- > tools/perf/util/config.c | 20 ++++ > tools/perf/util/config.h | 4 + > 4 files changed, 211 insertions(+), 3 deletions(-) >