Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933125AbcKNJLm (ORCPT ); Mon, 14 Nov 2016 04:11:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57670 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932883AbcKNJLE (ORCPT ); Mon, 14 Nov 2016 04:11:04 -0500 Date: Mon, 14 Nov 2016 17:10:59 +0800 From: Baoquan He To: Paul Menzel Cc: netdev@vger.kernel.org, michael.chan@broadcom.com, davem@davemloft.net, linux-kernel@vger.kernel.org, Dept-GELinuxNICDev@cavium.com, rasesh.mody@cavium.com, harish.patil@cavium.com, frank@undermydesk.org, jsr@dex.edzone.net, jroedel@suse.de, dyoung@redhat.com Subject: Re: [PATCH v2 0/2] bnx2: Wait for in-flight DMA to complete at probe stage Message-ID: <20161114091059.GB5845@x1> References: <1479013293-21001-1-git-send-email-bhe@redhat.com> <8010f40d-e7ca-8fd1-7317-f576289c112f@molgen.mpg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8010f40d-e7ca-8fd1-7317-f576289c112f@molgen.mpg.de> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 14 Nov 2016 09:11:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1278 Lines: 34 On 11/14/16 at 09:25am, Paul Menzel wrote: > Dear Baoquan, > > On 11/13/16 06:01, Baoquan He wrote: > > This is v2 post. > > > > In commit 3e1be7a ("bnx2: Reset device during driver initialization"), > > firmware requesting code was moved from open stage to probe stage. > > The reason is in kdump kernel hardware iommu need device be reset in > > driver probe stage, otherwise those in-flight DMA from 1st kernel > > will continue going and look up into the newly created io-page tables. > > However bnx2 chip resetting involves firmware requesting issue, that > > need be done in open stage. > > > > Michale Chan suggested we can just wait for the old in-flight DMA to > > complete at probe stage, then though without device resetting, we > > don't need to worry the old in-flight DMA could continue looking up > > the newly created io-page tables. > > > > v1->v2: > > Michael suggested to wait for the in-flight DMA to complete at probe > > stage. So give up the old method of trying to reset chip at probe > > stage, take the new way accordingly. > > thank you for posting the updated series. Could you please resend a v3 with > stable@vger.kernel.org added [1]? I can add it like: Cc: # 4.8.7 Only v4.8.7, right? Thanks Baoquan