Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933750AbcKNKLZ convert rfc822-to-8bit (ORCPT ); Mon, 14 Nov 2016 05:11:25 -0500 Received: from zimbra13.linbit.com ([212.69.166.240]:42971 "EHLO zimbra13.linbit.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754158AbcKNKLN (ORCPT ); Mon, 14 Nov 2016 05:11:13 -0500 Date: Mon, 14 Nov 2016 11:11:09 +0100 From: Lars Ellenberg To: Wolfgang Walter Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org Subject: Re: [Drbd-dev] DRBD: ASSERT in drbd_actlog.c:259 Message-ID: <20161114101109.GW1382@soda.linbit> Mail-Followup-To: Wolfgang Walter , drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org References: <6098334.rfGYZxPirJ@stwm.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <6098334.rfGYZxPirJ@stwm.de> User-Agent: Mutt/1.5.24 (2015-08-30) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2328 Lines: 62 On Fri, Nov 11, 2016 at 06:45:18PM +0100, Wolfgang Walter wrote: > Hello, > > when I execute > > mkfs.ext4 -J device=UUID=625d871f-c278-4acb-916d-774dc78dbd8a -v -b 4096 -E stride=$((512/4)),stripe_width=$((512/4*3)),lazy_itable_init=0 -O inline_data,mmp -L dyn -m .01 /dev/test/big > > the command hangs It should not hang, really, but it is probably too busy spewing below message to the console over and over again. There have been some problems with our trim/discard handling in some situations. That's also why this does not happen if you say nodiscard. > and the kernel (4.4.30) complains: > > block drbd1: ASSERT( (unsigned)(last - first) <= 1 ) in drivers/block/drbd/drbd_actlog.c:259 see: commit 505675f96cf0f169647a18c3dda1f373eca957b1 Author: Lars Ellenberg Date: Tue Jun 14 00:26:23 2016 +0200 drbd: allow larger max_discard_sectors Make sure we have at least 67 (> AL_UPDATES_PER_TRANSACTION) al-extents available, and allow up to half of that to be discarded in one bio. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg Signed-off-by: Jens Axboe diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c index d524973..265b2b6 100644 --- a/drivers/block/drbd/drbd_actlog.c +++ b/drivers/block/drbd/drbd_actlog.c @@ -258,7 +258,7 @@ bool drbd_al_begin_io_fastpath(struct drbd_device *device, struct drbd_interval unsigned first = i->sector >> (AL_EXTENT_SHIFT-9); unsigned last = i->size == 0 ? first : (i->sector + (i->size >> 9) - 1) >> (AL_EXTENT_SHIFT-9); - D_ASSERT(device, (unsigned)(last - first) <= 1); + D_ASSERT(device, first <= last); D_ASSERT(device, atomic_read(&device->local_cnt) > 0); /* FIXME figure out a fast path for bios crossing AL extent boundaries */ ... and some more chunks, but you should not cherry-pick stuff "just so", if it may change semantics ... kernel v4.4 is roughly equivalent to out-of-tree drbd 8.4.5, we are at 8.4.9 meanwhile, so you may want to try that as well. -- : Lars Ellenberg : LINBIT | Keeping the Digital World Running : DRBD -- Heartbeat -- Corosync -- Pacemaker : R&D, Integration, Ops, Consulting, Support DRBD? and LINBIT? are registered trademarks of LINBIT