Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933769AbcKNK0a (ORCPT <rfc822;w@1wt.eu>);
        Mon, 14 Nov 2016 05:26:30 -0500
Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:52998 "EHLO
        lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S933292AbcKNKZm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 14 Nov 2016 05:25:42 -0500
Subject: Re: [PATCH v3 3/9] media: venus: adding core part and helper
 functions
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
References: <1478540043-24558-1-git-send-email-stanimir.varbanov@linaro.org>
 <1478540043-24558-4-git-send-email-stanimir.varbanov@linaro.org>
 <f907ec9a-6d61-07f8-2135-f399e656d4e4@xs4all.nl>
 <2cdf728b-f58d-03fa-7ae4-58cbef4c4624@linaro.org>
 <a6557768-787d-7794-8cd0-781dc1ee9072@xs4all.nl>
 <dd5c0fef-4994-4beb-952f-659ff5d17fb0@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
From: Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <72f8675a-4771-3e9a-6ee0-6e1b86589e8f@xs4all.nl>
Date: Mon, 14 Nov 2016 11:25:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <dd5c0fef-4994-4beb-952f-659ff5d17fb0@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2033
Lines: 60

On 11/14/2016 11:11 AM, Stanimir Varbanov wrote:
> Hi Hans,
> 
> <cut>
> 
>>>>
>>>>> +void vidc_vb2_stop_streaming(struct vb2_queue *q)
>>>>> +{
>>>>> +	struct venus_inst *inst = vb2_get_drv_priv(q);
>>>>> +	struct venus_core *core = inst->core;
>>>>> +	struct device *dev = core->dev;
>>>>> +	struct vb2_queue *other_queue;
>>>>> +	struct vidc_buffer *buf, *n;
>>>>> +	enum vb2_buffer_state state;
>>>>> +	int ret;
>>>>> +
>>>>> +	if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
>>>>> +		other_queue = &inst->bufq_cap;
>>>>> +	else
>>>>> +		other_queue = &inst->bufq_out;
>>>>> +
>>>>> +	if (!vb2_is_streaming(other_queue))
>>>>> +		return;
>>>>
>>>> This seems wrong to me: this return means that the buffers of queue q are never
>>>> released. Either drop this 'if' or release both queues when the last queue
>>>> stops streaming. I think dropping the 'if' is best.
>>>
>>> I have done this way because hfi_session_stop must be called only once,
>>> and buffers will be released on first streamoff for both queues.
>>
>> Are you sure the buffers are released for both queues? I may have missed that when
>> reviewing.
> 
> yes, hfi_session_stop will instruct the firmware to stop using provided
> buffers and return ownership to the host driver by fill_buf_done and
> empty_buf_done callbacks.
> 
>>
>> I would recommend to call hfi_session_stop when the first stop_streaming is called,
>> not when it is called for both queues. I say this because stopping streaming without
>> releasing the buffers is likely to cause problems.
> 
> this is what I tried to implement with above
> !vb2_is_streaming(other_queue) thing.

That doesn't work: if the application calls STREAMON(CAPTURE) followed by STREAMOFF(CAPTURE)
without ever starting the OUTPUT queue, this will not clean up the capture queue.

Regards,

	Hans

> 
>>
>> Did you turn on CONFIG_VIDEO_ADV_DEBUG? If it is on, and you don't release buffers
>> then I think you will see warnings in the kernel log.
> 
> OK I will enable it to be sure that warnings are missing.
>