Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754244AbcKNK4O (ORCPT ); Mon, 14 Nov 2016 05:56:14 -0500 Received: from mga02.intel.com ([134.134.136.20]:46694 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbcKNK4L (ORCPT ); Mon, 14 Nov 2016 05:56:11 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,638,1473145200"; d="scan'208";a="786158130" From: Jani Nikula To: Fabian Frederick , Ben Skeggs Cc: fabf@skynet.be, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/1 linux-next] drm/nouveau: don't opencode IS_REACHABLE() In-Reply-To: <1478940498-2804-1-git-send-email-fabf@skynet.be> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1478940498-2804-1-git-send-email-fabf@skynet.be> Date: Mon, 14 Nov 2016 12:56:08 +0200 Message-ID: <87fumu2uuv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 555 Lines: 16 On Sat, 12 Nov 2016, Fabian Frederick wrote: > -#if defined(CONFIG_HWMON) || (defined(MODULE) && defined(CONFIG_HWMON_MODULE)) > +#if IS_REACHABLE(CONFIG_HWMON) The changes seem to make sense per se, but I'd be interested in hearing the rationale for not expressing this dependency in terms of Kconfig to begin with. With this, it's hidden in code, and the hwmon stuff gets used if the conditions for "nouveau depends on hwmon" are met, by chance, but it's not enforced. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center