Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933428AbcKNLE0 (ORCPT ); Mon, 14 Nov 2016 06:04:26 -0500 Received: from mga02.intel.com ([134.134.136.20]:23889 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752307AbcKNLEZ (ORCPT ); Mon, 14 Nov 2016 06:04:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,638,1473145200"; d="scan'208";a="1068164274" Message-ID: <1479121422.5295.148.camel@linux.intel.com> Subject: Re: [PATCH v4] i2c: designware: Implement support for SMBus block read and write From: Andy Shevchenko To: Alexander Stein , linux-kernel@vger.kernel.org Cc: tnhuynh@apm.com, Jarkko Nikula , Mika Westerberg , Wolfram Sang , linux-i2c@vger.kernel.org, Loc Ho , Thang Nguyen , Phong Vo , patches@apm.com Date: Mon, 14 Nov 2016 13:03:42 +0200 In-Reply-To: <4917823.j8OxAtZYNT@ws-stein> References: <1478746593-10905-1-git-send-email-tnhuynh@apm.com> <4917823.j8OxAtZYNT@ws-stein> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 42 On Mon, 2016-11-14 at 11:59 +0100, Alexander Stein wrote: > On Thursday 10 November 2016 09:56:33, tnhuynh@apm.com wrote: > > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c > > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c > > @@ -75,6 +75,7 @@ struct dw_pci_controller { > >   I2C_FUNC_SMBUS_BYTE | > > \ > >   I2C_FUNC_SMBUS_BYTE_DATA | > > \ > >   I2C_FUNC_SMBUS_WORD_DATA | > > \ > > + I2C_FUNC_SMBUS_BLOCK_DATA | > > \ > >   I2C_FUNC_SMBUS_I2C_BLOCK) > > > >  /* Merrifield HCNT/LCNT/SDA hold time */ > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c > > b/drivers/i2c/busses/i2c-designware-platdrv.c index 0b42a12..886fb62 > > 100644 > > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > > @@ -220,6 +220,7 @@ static int dw_i2c_plat_probe(struct > > platform_device > > *pdev) I2C_FUNC_SMBUS_BYTE | > >   I2C_FUNC_SMBUS_BYTE_DATA | > >   I2C_FUNC_SMBUS_WORD_DATA | > > + I2C_FUNC_SMBUS_BLOCK_DATA | > >   I2C_FUNC_SMBUS_I2C_BLOCK; > > > >   dev->master_cfg = DW_IC_CON_MASTER | > > DW_IC_CON_SLAVE_DISABLE | > > Shouldn't those functionality bits moved to a common place, like i2c- > designware-core.h? It would. But it's a separate story. So, if you are willing to do this, go ahead and send a patch. -- Andy Shevchenko Intel Finland Oy