Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933789AbcKNLhA (ORCPT ); Mon, 14 Nov 2016 06:37:00 -0500 Received: from mail-pg0-f42.google.com ([74.125.83.42]:33755 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbcKNLg5 (ORCPT ); Mon, 14 Nov 2016 06:36:57 -0500 Date: Mon, 14 Nov 2016 17:00:31 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Rafael Wysocki , Ingo Molnar , Peter Zijlstra , Lists linaro-kernel , Linux PM , Linux Kernel Mailing List , Vincent Guittot , Juri Lelli , Robin Randhawa Subject: Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier Message-ID: <20161114113031.GE4178@vireshk-i7> References: <1acfffe798c0371e69ec1171f485499e7b49ed6d.1478858983.git.viresh.kumar@linaro.org> <20161114040622.GA29087@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161114040622.GA29087@vireshk-i7> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 717 Lines: 21 On 14-11-16, 09:36, Viresh Kumar wrote: > On 13-11-16, 15:46, Rafael J. Wysocki wrote: > > That's only going to happen in the next patch, though, right? It > > wouldn't hurt to write that in the changelog too. > > Sure. > > > Besides, I'm not actually sure if starting/stopping the kthread in > > sugov_policy_alloc/free() is a good idea. It sort of conflates the > > allocation of memory with kthread creation. Any chance to untangle > > that? > > Hmm, so either I can create two new routines for the thread and call > them along with alloc/free. Or I can rename the alloc/free routines > and keep this patch as is. I have created separate routines in my new version (which I will send tomorrow). -- viresh