Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934756AbcKNMGM (ORCPT ); Mon, 14 Nov 2016 07:06:12 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58828 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753519AbcKNMFj (ORCPT ); Mon, 14 Nov 2016 07:05:39 -0500 Date: Mon, 14 Nov 2016 12:04:30 +0000 From: Mark Brown To: NeilBrown Cc: Baolin Wang , Felipe Balbi , Greg KH , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , robh@kernel.org, Jun Li , Marek Szyprowski , Ruslan Bilovol , Peter Chen , Alan Stern , grygorii.strashko@ti.com, Yoshihiro Shimoda , Lee Jones , John Stultz , Charles Keepax , patches@opensource.wolfsonmicro.com, Linux PM list , USB , device-mainlining@lists.linuxfoundation.org, LKML Message-ID: <20161114120430.hpnetdedyofhlkad@sirena.org.uk> References: <87k2cttptn.fsf@notabene.neil.brown.name> <87a8dls7yn.fsf@notabene.neil.brown.name> <871sytqrqh.fsf@notabene.neil.brown.name> <87a8dbni27.fsf@notabene.neil.brown.name> <87eg2ek7ye.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iubflgcycjlp7ucb" Content-Disposition: inline In-Reply-To: <87eg2ek7ye.fsf@notabene.neil.brown.name> X-Cookie: You can't fall off the floor. User-Agent: NeoMutt/20161104 (1.7.1) X-SA-Exim-Connect-IP: 92.40.248.132 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2344 Lines: 55 --iubflgcycjlp7ucb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 14, 2016 at 03:21:13PM +1100, NeilBrown wrote: > On Thu, Nov 10 2016, Baolin Wang wrote: > > Fourth, we need integrate all charger plugin/out > > event in one framework, not from extcon, maybe type-c in future. > Why not extcon? Given that a charger is connected by an external > connector, extcon seems like exactly the right thing to use. > Obviously extcon doesn't report the current that was negotiated, but > that is best kept separate. The battery charger can be advised of the > available current either via extcon or separately via the usb > subsystem. Don't conflate the two. Conflating the two seems like the whole point here. We're looking for something that sits between the power supply code and the USB code and tells the power supply code what it's allowed to do which is the result of a combination of physical cable detection and USB protocol. It seems reasonable that extcon drivers ought to be part of this but it doesn't seem like they are the whole story. > > word, we need one standard integration of this feature we need, though > > like you said we should do some clean up or fix to make it better. > But really, I'm not the person you need to convince. I'm just a vaguely > interested bystander who is rapidly losing interest. You need to > convince a maintainer, but they have so far shown remarkably little > interest. I don't know why, but I'd guess that reviewing a complex new > subsystem isn't much fun. Reviewing and applying clear bugfixes and > incremental improvements is much easier and more enjoyable. But that is > just a guess. OTOH having someone else having reviewed might help them apply something they don't care about. --iubflgcycjlp7ucb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAABCAAGBQJYKahOAAoJECTWi3JdVIfQgYwH/151x17Rs33bn9KTSNJJ3Vtw 0DjF1ncbUYMEokTPNWNxo8/x3XCQv8tFU7TTVps9ZUq7LjP5Y8aZovugPas7FXhC 8ozwgmL/SdG004C2GS6Tec60k+J32Wd5AeudYj5xeUJA14d/ZKs+cDqp+I+i8YOH x64g+8x9Nqs6nA282557HN3Wqf48SNHhYkZDs2xEsWxht4HYIpAQAFIxlId+6Y9u vUQ9ZtujYytP/76SRWV4F0HwYzmB2rPKwd1ftNpu5yqNAcIczLmRIAYYv69VRQQV mzQU76JEMjZP7USNrrgwjfeAgWqnmg0UwOPx8XZHD/uxSjCvdvmr0aePk/8KDlc= =VjTf -----END PGP SIGNATURE----- --iubflgcycjlp7ucb--