Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935530AbcKNMO2 (ORCPT ); Mon, 14 Nov 2016 07:14:28 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:15108 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934903AbcKNMOD (ORCPT ); Mon, 14 Nov 2016 07:14:03 -0500 From: Zubair Lutfullah Kakakhel To: , , , CC: , , , , Subject: [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx,kind-of-intr not provided Date: Mon, 14 Nov 2016 12:13:50 +0000 Message-ID: <20161114121351.10924-7-Zubair.Kakakhel@imgtec.com> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20161114121351.10924-1-Zubair.Kakakhel@imgtec.com> References: <20161114121351.10924-1-Zubair.Kakakhel@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.168.154.45] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 36 The powerpc dts file does not have the xlnx,kind-of-intr property. Instead of erroring out, give a warning instead. And attempt to continue to probe the interrupt controller while assuming kind-of-intr is 0x0 as a fall back. Signed-off-by: Zubair Lutfullah Kakakhel --- V6 -> V7 Rebase to v4.9-rc5 V5 -> V6 Rebase to v4.9-rc3 V5 new patch --- drivers/irqchip/irq-xilinx-intc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-xilinx-intc.c b/drivers/irqchip/irq-xilinx-intc.c index 971c141..d330917 100644 --- a/drivers/irqchip/irq-xilinx-intc.c +++ b/drivers/irqchip/irq-xilinx-intc.c @@ -179,8 +179,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc, ret = of_property_read_u32(intc, "xlnx,kind-of-intr", &irqc->intr_mask); if (ret < 0) { - pr_err("irq-xilinx: unable to read xlnx,kind-of-intr\n"); - goto err_alloc; + pr_warn("irq-xilinx: unable to read xlnx,kind-of-intr\n"); + irqc->intr_mask = 0; } if (irqc->intr_mask >> nr_irq) -- 2.10.2