Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753288AbcKNNz2 (ORCPT ); Mon, 14 Nov 2016 08:55:28 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35358 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbcKNNz0 (ORCPT ); Mon, 14 Nov 2016 08:55:26 -0500 Date: Mon, 14 Nov 2016 14:55:22 +0100 From: Ingo Molnar To: Matt Fleming Cc: Thomas Gleixner , "H . Peter Anvin" , Ard Biesheuvel , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Kees Cook Subject: Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table Message-ID: <20161114135521.GA10151@gmail.com> References: <20161112213237.8804-1-matt@codeblueprint.co.uk> <20161112213237.8804-6-matt@codeblueprint.co.uk> <20161113071939.GA31483@gmail.com> <20161114132334.GB2373@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161114132334.GB2373@codeblueprint.co.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2141 Lines: 57 * Matt Fleming wrote: > On Sun, 13 Nov, at 08:19:39AM, Ingo Molnar wrote: > > > > * Matt Fleming wrote: > > > > > From: Ard Biesheuvel > > > > > > Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and > > > install the Linux-specific RNG seed UEFI config table. This will be > > > picked up by the EFI routines in the core kernel to seed the kernel > > > entropy pool. > > > > > > Cc: Matt Fleming > > > Reviewed-by: Kees Cook > > > Signed-off-by: Ard Biesheuvel > > > > This commit (and the commits after this one) doesn't have a proper signoff chain, > > probably due to rebasing? > > Argh, my bad. This is fallout from moving to the co-maintainer model. > My scripts assume they don't need to append a SoB because that was > handled when applying the patch to the git tree. > > But that obviously doesn't hold if Ard applies the patch to git, but I > mail out the patches as part of the pull request (or vice versa). > > I guess in future you'd wanna see the SoB of the person mailing the > patches, right? The problem is not that Ard applied the patches, but that you subsequently rebased the tree. For example: commit bf5d1f98c1d8be04a40eabb9dd6913347b1b3fc4 Author: Ard Biesheuvel AuthorDate: Thu Oct 20 12:21:26 2016 +0100 Commit: Matt Fleming CommitDate: Sat Nov 12 21:14:41 2016 +0000 efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and install the Linux-specific RNG seed UEFI config table. This will be picked up by the EFI routines in the core kernel to seed the kernel entropy pool. Cc: Matt Fleming Reviewed-by: Kees Cook Signed-off-by: Ard Biesheuvel if you rebase it (with your co-maintainer's permission) then you need to add your SoB tag. Thanks, Ingo