From: Arnd Bergmann <arnd@arndb.de>
To: "pankaj.dubey" <pankaj.dubey@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        rmk+kernel@armlinux.org.uk, horms@verge.net.au, magnus.damm@gmail.com,
        geert+renesas@glider.be, vireshk@kernel.org,
        shiraz.linux.kernel@gmail.com, krzk@kernel.org, thomas.ab@samsung.com,
        Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH 04/16] ARM: realview: use generic API for enabling SCU
Date: Mon, 14 Nov 2016 15:28:58 +0100
Message-ID: <7078795.avIAjbub0e@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <95b10b29-2d51-9e96-c628-232f081e09f4@samsung.com>
References: <1479099731-28108-1-git-send-email-pankaj.dubey@samsung.com> <3587281.4kOCcW9Ryd@wuerfel> <95b10b29-2d51-9e96-c628-232f081e09f4@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 832
Lines: 24

On Monday, November 14, 2016 5:36:43 PM CET pankaj.dubey wrote:
> On Monday 14 November 2016 05:26 PM, Arnd Bergmann wrote:
> > On Monday, November 14, 2016 10:31:59 AM CET Pankaj Dubey wrote:
> > 
> > The only difference here seems to be that realview also needs to handle
> > "arm,arm11mp-scu". Why not move that into the generic implementation?
> > 
> 
> Do you mean "arm,arm11mp-scu" this is generic SCU specific to ARM?

Yes.

> If it's generic then it can be moved on the same line I moved a5-scu and
> a9-scu.
> 
> I left it here in same file, as I understood it might be related with
> very specific to realview platform.

The reason why only realview has it is that this is currently the
only platform we support that uses SMP on an ARM11MPcore.

cns3xxx in is also SMP hardware, but we only support the first core.

	ARnd