Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753757AbcKNPGK (ORCPT ); Mon, 14 Nov 2016 10:06:10 -0500 Received: from regular1.263xmail.com ([211.150.99.139]:38035 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751481AbcKNPGI (ORCPT ); Mon, 14 Nov 2016 10:06:08 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: shawn.lin@rock-chips.com X-SENDER-IP: 211.97.167.143 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: <5503510f6a31d178cdc3df0a0ffce5bb> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5829D2D3.2050808@rock-chips.com> Date: Mon, 14 Nov 2016 23:05:55 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Shawn Lin CC: Caesar Wang , Heiko Stuebner , Mark Rutland , devicetree@vger.kernel.org, Brian Norris , linux-kernel@vger.kernel.org, Catalin Marinas , Elaine Zhang , Will Deacon , Douglas Anderson , tfiga@chromium.org, linux-rockchip@lists.infradead.org, Rob Herring , eddie.cai@rock-chips.com, David Wu , Jianqun Xu , linux-arm-kernel@lists.infradead.org, Ziyuan Xu Subject: Re: [PATCH v2 1/9] arm64: dts: rockchip: add eMMC's power domain support for rk3399 References: <1478697721-2323-1-git-send-email-wxt@rock-chips.com> <1478697721-2323-2-git-send-email-wxt@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2055 Lines: 82 On 2016年11月12日 12:22, Shawn Lin wrote: > On 2016/11/9 21:21, Caesar Wang wrote: >> From: Ziyuan Xu >> >> Control power domain for eMMC via genpd to reduce power consumption. >> >> Signed-off-by: Elaine Zhang >> Signed-off-by: Ziyuan Xu >> Signed-off-by: Caesar Wang > > It was verified on my rk3399 evb with kernel4.4, so > free feel to add my tag, > > Tested-by: Shawn Lin > Thanks the tests. > BTW, it seems my reply is bounced form Yakir's address, so please > remove him from CC list if he changed his mail address. Right, Yakir's (ykk@rock-chips.com) address had left this world.;-) But the patman tool is auto sending with the Cc people. - Caesar > >> --- >> >> Changes in v2: >> - Reviewed-on: https://chromium-review.googlesource.com/376558 >> - Verified on ChromeOS kernel4.4 >> >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> index cbb7f8b..b401176 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -269,6 +269,7 @@ >> #clock-cells = <0>; >> phys = <&emmc_phy>; >> phy-names = "phy_arasan"; >> + power-domains = <&power RK3399_PD_EMMC>; >> status = "disabled"; >> }; >> >> @@ -690,6 +691,11 @@ >> status = "disabled"; >> }; >> >> + qos_emmc: qos@ffa58000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffa58000 0x0 0x20>; >> + }; >> + >> qos_gmac: qos@ffa5c000 { >> compatible = "syscon"; >> reg = <0x0 0xffa5c000 0x0 0x20>; >> @@ -823,6 +829,11 @@ >> }; >> >> /* These power domains are grouped by VD_LOGIC */ >> + pd_emmc@RK3399_PD_EMMC { >> + reg = ; >> + clocks = <&cru ACLK_EMMC>; >> + pm_qos = <&qos_emmc>; >> + }; >> pd_gmac@RK3399_PD_GMAC { >> reg = ; >> clocks = <&cru ACLK_GMAC>; >> > > -- caesar wang | software engineer | wxt@rock-chip.com