Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754676AbcKNPsO (ORCPT ); Mon, 14 Nov 2016 10:48:14 -0500 Received: from mail-yb0-f195.google.com ([209.85.213.195]:34861 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753610AbcKNPsK (ORCPT ); Mon, 14 Nov 2016 10:48:10 -0500 Date: Mon, 14 Nov 2016 09:48:07 -0600 From: Rob Herring To: Laxman Dewangan Cc: broonie@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Douglas Anderson , Aleksandr Frid Subject: Re: [PATCH 1/2] regulator: pwm: DT: Add ramp delay for exponential voltage transition Message-ID: <20161114154807.j4oo4veslhknauxy@rob-hp-laptop> References: <1478281075-3498-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478281075-3498-1-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1655 Lines: 39 On Fri, Nov 04, 2016 at 11:07:54PM +0530, Laxman Dewangan wrote: > Some PWM regulator has the exponential transition in voltage change as > opposite to fixed slew-rate linear transition on other regulators. > For such PWM regulators, add the property for providing the delay > from DT node. > > Add DT binding details of the new property > "pwm-regulator-voltage-ramp-time-us" added for providing voltage > transition delay. > > Signed-off-by: Laxman Dewangan > CC: Douglas Anderson > CC: Aleksandr Frid > > --- > This patch is continuation of discussion on patch > regulator: pwm: Fix regulator ramp delay for continuous mode > https://patchwork.kernel.org/patch/9216857/ > where is it discussed to have separate property for PWM which has > exponential voltage transition. > --- > Documentation/devicetree/bindings/regulator/pwm-regulator.txt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/pwm-regulator.txt b/Documentation/devicetree/bindings/regulator/pwm-regulator.txt > index 3aeba9f..a163f42 100644 > --- a/Documentation/devicetree/bindings/regulator/pwm-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/pwm-regulator.txt > @@ -54,6 +54,16 @@ Optional properties: > -------------------- > - enable-gpios: GPIO to use to enable/disable the regulator > > +- pwm-regulator-voltage-ramp-time-us: Integer, voltage ramp time in This is a really long name. Drop the 'pwm-regulator-' part as it is redundant. The fact that it is PWM reg specific is captured as it is documented that way. Rob