Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754351AbcKNPvB (ORCPT <rfc822;w@1wt.eu>);
        Mon, 14 Nov 2016 10:51:01 -0500
Received: from mail.kernel.org ([198.145.29.136]:42844 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752007AbcKNPu6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 14 Nov 2016 10:50:58 -0500
Date: Mon, 14 Nov 2016 12:50:50 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Wang Nan <wangnan0@huawei.com>,
        Nambong Ha <over3025@gmail.com>, Wookje Kwon <aweee0@gmail.com>
Subject: Re: [PATCH 1/6] perf config: Add support for getting config
 key-value pairs
Message-ID: <20161114155050.GB26543@kernel.org>
References: <1478241862-31230-1-git-send-email-treeze.taeung@gmail.com>
 <1478241862-31230-2-git-send-email-treeze.taeung@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1478241862-31230-2-git-send-email-treeze.taeung@gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3133
Lines: 110

Em Fri, Nov 04, 2016 at 03:44:17PM +0900, Taeung Song escreveu:
> Add a functionality getting specific config key-value pairs.
> For the syntax examples,
> 
>     perf config [<file-option>] [section.name ...]
> 
> e.g. To query config items 'report.queue-size' and 'report.children', do
> 
>     # perf config report.queue-size report.children

So, I'm applying it, but while testing I noticed that it shows only the
options that were explicitely set:

[acme@jouet linux]$ perf config report.queue-size report.children
report.children=false
[acme@jouet linux]$

Perhaps we should, in a follow up patch, show this instead:

[acme@jouet linux]$ perf config report.queue-size report.children
report.children=false
# report.queue-size=18446744073709551615 # Default, not set in ~/.perfconfig
[acme@jouet linux]$

?

- Arnaldo
 
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Wang Nan <wangnan0@huawei.com>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
>  tools/perf/builtin-config.c | 40 +++++++++++++++++++++++++++++++++++++---
>  1 file changed, 37 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
> index e4207a2..df3fa1c 100644
> --- a/tools/perf/builtin-config.c
> +++ b/tools/perf/builtin-config.c
> @@ -17,7 +17,7 @@
>  static bool use_system_config, use_user_config;
>  
>  static const char * const config_usage[] = {
> -	"perf config [<file-option>] [options]",
> +	"perf config [<file-option>] [options] [section.name ...]",
>  	NULL
>  };
>  
> @@ -33,6 +33,36 @@ static struct option config_options[] = {
>  	OPT_END()
>  };
>  
> +static int show_spec_config(struct perf_config_set *set, const char *var)
> +{
> +	struct perf_config_section *section;
> +	struct perf_config_item *item;
> +
> +	if (set == NULL)
> +		return -1;
> +
> +	perf_config_items__for_each_entry(&set->sections, section) {
> +		if (prefixcmp(var, section->name) != 0)
> +			continue;
> +
> +		perf_config_items__for_each_entry(&section->items, item) {
> +			const char *name = var + strlen(section->name) + 1;
> +
> +			if (strcmp(name, item->name) == 0) {
> +				char *value = item->value;
> +
> +				if (value) {
> +					printf("%s=%s\n", var, value);
> +					return 0;
> +				}
> +			}
> +
> +		}
> +	}
> +
> +	return 0;
> +}
> +
>  static int show_config(struct perf_config_set *set)
>  {
>  	struct perf_config_section *section;
> @@ -54,7 +84,7 @@ static int show_config(struct perf_config_set *set)
>  
>  int cmd_config(int argc, const char **argv, const char *prefix __maybe_unused)
>  {
> -	int ret = 0;
> +	int i, ret = 0;
>  	struct perf_config_set *set;
>  	char *user_config = mkpath("%s/.perfconfig", getenv("HOME"));
>  
> @@ -100,7 +130,11 @@ int cmd_config(int argc, const char **argv, const char *prefix __maybe_unused)
>  		}
>  		break;
>  	default:
> -		usage_with_options(config_usage, config_options);
> +		if (argc)
> +			for (i = 0; argv[i]; i++)
> +				ret = show_spec_config(set, argv[i]);
> +		else
> +			usage_with_options(config_usage, config_options);
>  	}
>  
>  	perf_config_set__delete(set);
> -- 
> 2.7.4