Message-ID: <1479140119.3755.20.camel@decadent.org.uk>
Subject: Re: [PATCH 3.2 009/152] ext4: check for extents that wrap around
From: Ben Hutchings <ben@decadent.org.uk>
To: Vegard Nossum <vegard.nossum@oracle.com>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: akpm@linux-foundation.org, Phil Turnbull <phil.turnbull@oracle.com>,
        Eryu Guan <guaneryu@gmail.com>, "Theodore Ts'o" <tytso@mit.edu>
Date: Mon, 14 Nov 2016 16:15:19 +0000
In-Reply-To: <8ccb2d1b-cc2d-7e30-836b-47d56591365b@oracle.com>
References: <lsq.1479082447.702293527@decadent.org.uk>
         <8ccb2d1b-cc2d-7e30-836b-47d56591365b@oracle.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-71IQyjpOFZ/+050HgESY"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2319
Lines: 61


--=-71IQyjpOFZ/+050HgESY
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2016-11-14 at 16:29 +0100, Vegard Nossum wrote:
> On 11/14/2016 01:14 AM, Ben Hutchings wrote:
> > 3.2.84-rc1 review patch.=C2=A0=C2=A0If anyone has any objections, pleas=
e let me know.
>=20
> Just a general comment on stable review workflow, really:
>=20
> It might be more useful to send the diff-of-diffs with the upstream
> commit so I can easily see if you had any conflicts when cherry-picking
> this and how they were resolved.

When there are conflicts, I explain how they were resolved before my
Signed-off-by: line.  In this case there were none.

I'm not going to change to diff-of-diffs unless there is consensus for
this among stable=C2=A0maintainers and reviewers.

[...]
> If you could push this commit to git before sending the review, you
> could also include a command that I can use to quickly do the
> diff-of-diffs myself without having to download and apply the patch (or
> look for it), e.g. something like (using the 3.12 stable commit vs
> upstream):
[...]

You can find all the patches in a 3.2-rc or 3.16-rc review at
<https://git.kernel.org/cgit/linux/kernel/git/bwh/linux-stable-queue.git/>.

Ben.

--=20
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.

--=-71IQyjpOFZ/+050HgESY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIcBAABCgAGBQJYKeMXAAoJEOe/yOyVhhEJSPYP/3jtFEOQBRdYQgbM4dw1e3JO
zBznmFo8b5Wx+CwNdmLIE2KJGYUmMXS8hYPGWVWHBDZfwlHNhTbHy6aPQ7hhVPb8
j+Fb3mcAWmLvK+NcWOomJTioQEXhLixL1bHLKA8knVIExXm8e1byq4Z47BXw6AXk
bm9QQJe3lSVL/cI6Mx2f8EIqgWNGzRYYzCA4Y7fgV63MZT7ipp9wOEpch4GPdH0b
MYLbFYnajWvzFsmjPaGRoCP3qln4mcCcFzCKwZGmvVLpkUTO4zaiwooiuIcdVVqP
W4Nbqedz59NihdRUd850nWExm06vs4YoIw4bRI94T9TnvPYfVpC1t7rXvtPkKE8Y
FSfZlfV/3D7ivMep0Umfnj0rD6qTS2pPhuMr8aOU2DvoRHxxhU9rJyiBqrnekD9v
GygvO15wUx1vluhNhuQnd+mdlU9cM+LBOpthM5VSwVWY3caaANrS+EXENaclh9cv
xH7sAWTgsAafL0FPP633gFW8kZOdyOUiXLLHlea8U6f+E+den5V1Rf8rDHQFtkf6
BMzFhZLU0kZMyEgeFd3My6Gh+33JnKBnAceTPhQ842Dikey3cJFWm02SmsmcKgHv
18R1CslfyRspwvy7CcjLqb9inWkfd1EpChUg9NBRHXGkpVfqRpWMQaPk1PsaR2Mg
gwCwcKg9V3GX/xgFqvgW
=+qFH
-----END PGP SIGNATURE-----

--=-71IQyjpOFZ/+050HgESY--