Date: Wed, 07 May 2003 20:32:04 -0700
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Andi Kleen <ak@muc.de>, Andrew Morton <akpm@digeo.com>
cc: linux-kernel@vger.kernel.org, "Randy.Dunlap" <rddunlap@osdl.org>
Subject: Re: garbled oopsen
Message-ID: <23400000.1052364724@[10.10.2.4]>
In-Reply-To: <m34r46dufb.fsf@averell.firstfloor.org>
References: <20030508011013$3d80@gated-at.bofh.it><20030508015008$481c@gated-at.bofh.it> <m34r46dufb.fsf@averell.firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1018
Lines: 24

>>> Can these be cleaned up in any reasonable way?
>> 
>> It needs some additional spinlock in there.  People have moaned for over a
>> year, patches have been floating about but nobody has taken the time to
>> finish one off and submit it.
> 
> I considered it for x86-64 and even implemented it, but never submitted
> in fear of deadlocks e.g. when an oops recurses. For this a 
> spinlock_timeout() would be useful. Print anyways when you cannot get the
> lock in a second or two.

The trouble is that the subsystems you want may be broken (eg timers).
IMHO it's better to just spew whatever you can (the current crap) ... 
wait a couple of seconds, then have another go at doing it properly.

That way people can't complain it's worse than it is now in any way ;-)

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/