Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936457AbcKNScA (ORCPT ); Mon, 14 Nov 2016 13:32:00 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33386 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935053AbcKNSbz (ORCPT ); Mon, 14 Nov 2016 13:31:55 -0500 Subject: Re: [patch] HID: wacom: Don't clear bits unintentionally To: Dan Carpenter , Jiri Kosina References: <20161110192539.GA32533@mwanda> Cc: Benjamin Tissoires , Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Jason Gerecke Message-ID: <56caefcd-93d6-201d-f597-2d651cbe68ba@gmail.com> Date: Mon, 14 Nov 2016 10:31:52 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161110192539.GA32533@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 32 On 11/10/2016 11:25 AM, Dan Carpenter wrote: > This is trying to clear the lower 32 bits but the type is wrong so it > clears everything. > > Signed-off-by: Dan Carpenter > Reviewed-by: Jason Gerecke Jason --- Now instead of four in the eights place / you?ve got three, ?Cause you added one / (That is to say, eight) to the two, / But you can?t take seven from three, / So you look at the sixty-fours.... > diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c > index 0723ba8..1cf4608 100644 > --- a/drivers/hid/wacom_wac.c > +++ b/drivers/hid/wacom_wac.c > @@ -1765,7 +1765,7 @@ static int wacom_wac_pen_event(struct hid_device *hdev, struct hid_field *field, > wacom_wac->hid_data.tipswitch |= value; > return 0; > case HID_DG_TOOLSERIALNUMBER: > - wacom_wac->serial[0] = (wacom_wac->serial[0] & ~0xFFFFFFFF); > + wacom_wac->serial[0] = (wacom_wac->serial[0] & ~0xFFFFFFFFULL); > wacom_wac->serial[0] |= value; > return 0; > case WACOM_HID_WD_SENSE: > --