Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936530AbcKNScS (ORCPT ); Mon, 14 Nov 2016 13:32:18 -0500 Received: from mail-pf0-f170.google.com ([209.85.192.170]:34051 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934199AbcKNScQ (ORCPT ); Mon, 14 Nov 2016 13:32:16 -0500 From: Rob Rice To: Jassi Brar Cc: bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, Steve Lin , Rob Rice Subject: [PATCH 03/11] mailbox: bcm-pdc: PDC driver leaves debugfs files after removal Date: Mon, 14 Nov 2016 13:25:57 -0500 Message-Id: <1479147965-29662-4-git-send-email-rob.rice@broadcom.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1479147965-29662-1-git-send-email-rob.rice@broadcom.com> References: <1479147965-29662-1-git-send-email-rob.rice@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1097 Lines: 34 From: Steve Lin Minor fix to ensure that debugfs stats pseudo-files are removed when driver module is unloaded. Previously, the call to debugfs_remove_recursive() was never being called since the directory was not empty, and a seg fault would occur if another process tried to access these leftover files. Signed-off-by: Steve Lin Signed-off-by: Rob Rice Reviewed-by: Andy Gospodarek --- drivers/mailbox/bcm-pdc-mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/bcm-pdc-mailbox.c b/drivers/mailbox/bcm-pdc-mailbox.c index 3b4ebbe..c9434a7 100644 --- a/drivers/mailbox/bcm-pdc-mailbox.c +++ b/drivers/mailbox/bcm-pdc-mailbox.c @@ -492,10 +492,8 @@ static void pdc_setup_debugfs(struct pdc_state *pdcs) static void pdc_free_debugfs(void) { - if (debugfs_dir && simple_empty(debugfs_dir)) { - debugfs_remove_recursive(debugfs_dir); - debugfs_dir = NULL; - } + debugfs_remove_recursive(debugfs_dir); + debugfs_dir = NULL; } /** -- 2.1.0